Java: Add command BITCOUNT
#263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Guian Gumpac <guian.gumpac@improving.com>
Signed-off-by: Guian Gumpac <guian.gumpac@improving.com>
java/client/src/main/java/glide/api/commands/BitmapBaseCommands.java
Outdated
Show resolved
Hide resolved
java/client/src/main/java/glide/api/commands/BitmapBaseCommands.java
Outdated
Show resolved
Hide resolved
java/client/src/main/java/glide/api/models/BaseTransaction.java
Outdated
Show resolved
Hide resolved
java/client/src/main/java/glide/api/models/BaseTransaction.java
Outdated
Show resolved
Hide resolved
java/client/src/main/java/glide/api/models/BaseTransaction.java
Outdated
Show resolved
Hide resolved
java/client/src/main/java/glide/api/models/BaseTransaction.java
Outdated
Show resolved
Hide resolved
java/client/src/main/java/glide/api/models/commands/BitcountOptions.java
Outdated
Show resolved
Hide resolved
java/client/src/main/java/glide/api/models/commands/BitcountOptions.java
Outdated
Show resolved
Hide resolved
java/integTest/src/test/java/glide/TransactionTestUtilities.java
Outdated
Show resolved
Hide resolved
tjzhang-BQ
reviewed
May 3, 2024
java/client/src/main/java/glide/api/commands/BitmapBaseCommands.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Guian Gumpac <guian.gumpac@improving.com>
java/client/src/main/java/glide/api/commands/BitmapBaseCommands.java
Outdated
Show resolved
Hide resolved
java/client/src/main/java/glide/api/commands/BitmapBaseCommands.java
Outdated
Show resolved
Hide resolved
java/client/src/main/java/glide/api/models/commands/BitcountOptions.java
Outdated
Show resolved
Hide resolved
java/client/src/main/java/glide/api/models/commands/BitcountOptions.java
Outdated
Show resolved
Hide resolved
java/client/src/main/java/glide/api/models/BaseTransaction.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Guian Gumpac <guian.gumpac@improving.com>
Yury-Fridlyand
approved these changes
May 6, 2024
| * | ||
| * @see <a href="https://redis.io/commands/bitcount/">redis.io</a> | ||
| */ | ||
| @RequiredArgsConstructor |
| @@ -178,6 +179,10 @@ public static BaseTransaction<?> transactionTest(BaseTransaction<?> baseTransact | |||
| .pfmerge(hllKey3, new String[] {hllKey1, hllKey2}) | |||
| .pfcount(new String[] {hllKey3}); | |||
|
|
|||
| baseTransaction.bitcount(key3); | |||
| baseTransaction.bitcount(key3, 2, 4); | |||
| baseTransaction.bitcount(key3, 2, 19, BitMapOptions.BIT); | |||
There was a problem hiding this comment.
Remove this test - it fails on redis 6.
It is ok to omit it, but if you want to test this in transaction - create a separate test cases for cluster and standalone client. Or wait for valkey-io#1284.
There was a problem hiding this comment.
As discussed, it's better to wait for valkey-io#1284. Will add to PR to ignore GHA failures.
Signed-off-by: Guian Gumpac <guian.gumpac@improving.com>
GumpacG
added a commit
that referenced
this pull request
May 6, 2024
* Implemented Bitcount command for java client Signed-off-by: Guian Gumpac <guian.gumpac@improving.com> * Removed unrelated change Signed-off-by: Guian Gumpac <guian.gumpac@improving.com> * Addressed PR comments Signed-off-by: Guian Gumpac <guian.gumpac@improving.com> * Addressed PR comments Signed-off-by: Guian Gumpac <guian.gumpac@improving.com> * Removed unnecessary constructor Signed-off-by: Guian Gumpac <guian.gumpac@improving.com> --------- Signed-off-by: Guian Gumpac <guian.gumpac@improving.com>
GumpacG
added a commit
that referenced
this pull request
May 10, 2024
* Implemented Bitcount command for java client Signed-off-by: Guian Gumpac <guian.gumpac@improving.com> * Removed unrelated change Signed-off-by: Guian Gumpac <guian.gumpac@improving.com> * Addressed PR comments Signed-off-by: Guian Gumpac <guian.gumpac@improving.com> * Addressed PR comments Signed-off-by: Guian Gumpac <guian.gumpac@improving.com> * Removed unnecessary constructor Signed-off-by: Guian Gumpac <guian.gumpac@improving.com> --------- Signed-off-by: Guian Gumpac <guian.gumpac@improving.com>
Yury-Fridlyand
pushed a commit
that referenced
this pull request
May 10, 2024
* Java: Add command `BITCOUNT` (#263) * Implemented Bitcount command for java client Signed-off-by: Guian Gumpac <guian.gumpac@improving.com> * Removed unrelated change Signed-off-by: Guian Gumpac <guian.gumpac@improving.com> * Addressed PR comments Signed-off-by: Guian Gumpac <guian.gumpac@improving.com> * Addressed PR comments Signed-off-by: Guian Gumpac <guian.gumpac@improving.com> * Removed unnecessary constructor Signed-off-by: Guian Gumpac <guian.gumpac@improving.com> --------- Signed-off-by: Guian Gumpac <guian.gumpac@improving.com> * Resolved conflicts Signed-off-by: Guian Gumpac <guian.gumpac@improving.com> * Renamed interface for consistency Signed-off-by: Guian Gumpac <guian.gumpac@improving.com> * Address PR comments Signed-off-by: Guian Gumpac <guian.gumpac@improving.com> * Added missed javadoc Signed-off-by: Guian Gumpac <guian.gumpac@improving.com> * Addressed comments Signed-off-by: Guian Gumpac <guian.gumpac@improving.com> * Update java/client/src/main/java/glide/api/commands/BitmapBaseCommands.java Co-authored-by: Aaron <69273634+aaron-congo@users.noreply.github.com> * Update java/client/src/main/java/glide/api/commands/BitmapBaseCommands.java Co-authored-by: Aaron <69273634+aaron-congo@users.noreply.github.com> * addressed PR comments Signed-off-by: Guian Gumpac <guian.gumpac@improving.com> * Addressed PR comments Signed-off-by: Guian Gumpac <guian.gumpac@improving.com> * Removed wrong version check Signed-off-by: Guian Gumpac <guian.gumpac@improving.com> * Rebased and resolved conflicts Signed-off-by: Guian Gumpac <guian.gumpac@improving.com> --------- Signed-off-by: Guian Gumpac <guian.gumpac@improving.com> Co-authored-by: Aaron <69273634+aaron-congo@users.noreply.github.com>
cyip10
pushed a commit
that referenced
this pull request
Jun 24, 2024
* Java: Add command `BITCOUNT` (#263) * Implemented Bitcount command for java client Signed-off-by: Guian Gumpac <guian.gumpac@improving.com> * Removed unrelated change Signed-off-by: Guian Gumpac <guian.gumpac@improving.com> * Addressed PR comments Signed-off-by: Guian Gumpac <guian.gumpac@improving.com> * Addressed PR comments Signed-off-by: Guian Gumpac <guian.gumpac@improving.com> * Removed unnecessary constructor Signed-off-by: Guian Gumpac <guian.gumpac@improving.com> --------- Signed-off-by: Guian Gumpac <guian.gumpac@improving.com> * Resolved conflicts Signed-off-by: Guian Gumpac <guian.gumpac@improving.com> * Renamed interface for consistency Signed-off-by: Guian Gumpac <guian.gumpac@improving.com> * Address PR comments Signed-off-by: Guian Gumpac <guian.gumpac@improving.com> * Added missed javadoc Signed-off-by: Guian Gumpac <guian.gumpac@improving.com> * Addressed comments Signed-off-by: Guian Gumpac <guian.gumpac@improving.com> * Update java/client/src/main/java/glide/api/commands/BitmapBaseCommands.java Co-authored-by: Aaron <69273634+aaron-congo@users.noreply.github.com> * Update java/client/src/main/java/glide/api/commands/BitmapBaseCommands.java Co-authored-by: Aaron <69273634+aaron-congo@users.noreply.github.com> * addressed PR comments Signed-off-by: Guian Gumpac <guian.gumpac@improving.com> * Addressed PR comments Signed-off-by: Guian Gumpac <guian.gumpac@improving.com> * Removed wrong version check Signed-off-by: Guian Gumpac <guian.gumpac@improving.com> * Rebased and resolved conflicts Signed-off-by: Guian Gumpac <guian.gumpac@improving.com> --------- Signed-off-by: Guian Gumpac <guian.gumpac@improving.com> Co-authored-by: Aaron <69273634+aaron-congo@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement https://redis.io/docs/latest/commands/bitcount/ in the java client.