Some development improvements and fixes #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredyk
commented
Nov 10, 2017
fredyk
commented
- (Added) Show long months
- (Fixed) Leap years have 29 days in February
- (Added) Use custom font
- (Added) maxDate
- (Fixed) Prevent an IndexOutOfBoundsException at onDateSelected
- (Fixed) Properly access months and days array while setting initial positions
- (Fixed) decreasing dayPos while changing to a shorter month
- (Fixed) calculate maxTextHeight with a "j" to support lowerCase month names
- (Fixed) Leap years have 29 days in February - (Added) Use custom font - (Added) maxDate - (Fixed) Prevent an IndexOutOfBoundsException at onDateSelected - (Fixed) Properly access months and days array while setting initial positions - (Fixed) decreasing dayPos while changing to a shorter month - (Fixed) calculate maxTextHeight with a "j" to support lowerCase month names
JonatanSalas
requested changes
Nov 11, 2017
There was a problem hiding this comment.
These are the only changes I would like you to do:
- In order to keep the code aligned, rename the variable "mFont" for "font" or "fontTypeface".
- Rename the setFont setter for setTypeface to keep the code aligned with the android API.
- Add brackets to if/else when generating the Typeface.
|
@fredyk Also, I want to thank you for opening a PR offering bug fixes and code improvement! 😄 |
|
I would like to kindly ask you to close this pull request in order to create another from the master branch with just bug fixes, so that I can continue developing my own version in the develop branch, making improvements without impairing yours, and creating successive pull requests. By the way, from my own experience,I would like to suggest you to create your own developing and pre-release branches (It gave me a better control over my changes ;) ). Adiós y un saludo! |
|
Great! I will do it so! Thanks for the advice! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.