Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds typescript language basic data types #121

Merged
merged 4 commits into from
Feb 7, 2021

Conversation

MortezaHeydari97
Copy link
Contributor

I'm begin typescript tutorial and I will complete it

@amireshoon
Copy link
Collaborator

Thank you for your contribution but I think it's not cool to write your name in the EOF's. your name will be added to repo CONTRIBUTE_LIST.md there is no need to write it there. Also instead of removing other contributor names add your name like this.

{
    "creator": [
    {
        "title": "Amirhossein Mohammadi",
        "link": "https://github.com/BlackIQ"
    },{
        "title": "<name>",
        "link": "<profile_url>"
    }
   ]
} 

Multiple contributors will add soon.

@amireshoon amireshoon mentioned this pull request Feb 7, 2021
@amireshoon
Copy link
Collaborator

Due to PR #123 Multiple contributors are now supported

@parsampsh
Copy link
Collaborator

Wait... I'm merging...

Copy link
Collaborator

@parsampsh parsampsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All done. @amireshoon Is it ok?

@parsampsh parsampsh merged commit 9290480 into BlackIQ:main Feb 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants