Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signal support for scratchpads #67

Closed
Nooo37 opened this issue Jun 14, 2021 · 1 comment
Closed

Signal support for scratchpads #67

Nooo37 opened this issue Jun 14, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@Nooo37
Copy link
Member

Nooo37 commented Jun 14, 2021

We've had that idea before, I'll communicate it in this issue so that we don't forget about it and in case someone is interested in contributing.

It would be cool to have scratchpads support some basic signals such as open and close so that the user might intervene in some scratchpad actions and customize it even further from there on. For example the use case of an "option to disable the client floating state when closing the scratchpad" as mentioned in #63 should be achievable by doing something like my_scratchpad:connect_signal("close", function(c) c.floating = false end) which would be very intuitive to awesomewm users.

Adding basic signals would probably not even be that hard. We could just keep a list of functions for each signal as an object property that are run when the scratchpad opens/closes. connect_signal would then just add a function to the corresponding list. There are some implementation details to work out though but the concept should be clear.

@Nooo37 Nooo37 added the enhancement New feature or request label Jun 14, 2021
@Nooo37 Nooo37 mentioned this issue Jul 27, 2021
2 tasks
@Nooo37
Copy link
Member Author

Nooo37 commented Aug 4, 2021

Has been added in #82

@Nooo37 Nooo37 closed this as completed Aug 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant