Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Magpie stops scaling the game window #959

Open
rampaa opened this issue Jun 30, 2024 · 7 comments
Open

Magpie stops scaling the game window #959

rampaa opened this issue Jun 30, 2024 · 7 comments
Labels
bug Something isn't working

Comments

@rampaa
Copy link

rampaa commented Jun 30, 2024

Magpie version 程序版本

0.11.1

Windows version 系统版本

Windows 10 22H2

Related screenshot (optional) 相关截图(可选)

Hy4mgdivdl.mp4

Reproduction steps 复现步骤

  1. Install https://vndb.org/r37327
  2. Add a profile for the game and enable the "Auto scale when in foreground" option.
  3. Skip until you see the first option in the game. After the first option, any time an in-game "video" ends, Magpie stops scaling the game window and does not start re-scaling it again without game window losing and re-gaining the focus.

I tried to change the following settings but they didn't solve the problem: "Capture method", "3D game mode", "Disable window resizing while scaling", "Capture title bar", "Disable DirectFlip".

Log files 日志文件

magpie.log

@rampaa rampaa added the bug Something isn't working label Jun 30, 2024
@rampaa
Copy link
Author

rampaa commented Jun 30, 2024

In case it's useful: Magpie v0.9.1 auto re-scales the aforementioned game's window after it stops scaling it. v0.10.0 onwards though it doesn't, as shown in the video.

@Blinue
Copy link
Owner

Blinue commented Jun 30, 2024

Where can I get a copy of the game? It looks like there's a trial version available, but I can't find the download link.

@rampaa
Copy link
Author

rampaa commented Jun 30, 2024

The trial version can be downloaded from: http://suezou.dyndns.org/dl2011/jellyfish/sisters/SISTERS_PLAYABLE_DEMO.zip

But I can't reproduce the problem with the trial version, it seems pretty different from the Ultra Edition. I can send some links about the Ultra Edition to your e-mail address if you don't mind sharing it.

@Blinue
Copy link
Owner

Blinue commented Jun 30, 2024

I couldn't reproduce the issue with the trial version either. I plan to implement persistent scaling in the future, so I don't want to spend too much time on this issue right now. Thank you for reporting it!

@rampaa
Copy link
Author

rampaa commented Jun 30, 2024

I plan to implement persistent scaling in the future

What does that entail exactly? Would it also solve #538?

so I don't want to spend too much time on this issue right now

Sounds reasonable, I will just use the Magpie v0.9.1 for this specific game.

Thank you for reporting it!

Thank you for developing this marvelous tool.

@Blinue
Copy link
Owner

Blinue commented Jun 30, 2024

What does that entail exactly? Would it also solve #538?

The plan is to maintain scaling even when switching windows, allowing the scaling window to stay in the background (the scaling window is not top-most anymore). Once implemented, this should resolve all unexpected scaling interruptions. This feature might be introduced alongside windowed mode.

@antoniodesousa
Copy link

antoniodesousa commented Jul 7, 2024

The plan is to maintain scaling even when switching windows, allowing the scaling window to stay in the background (the scaling window is not top-most anymore). Once implemented, this should resolve all unexpected scaling interruptions. This feature might be introduced alongside windowed mode.

This will be awesome! I'm facing the same issue with multiple games in TeknoParrot (it's an arcade emulator) where the game window is clearly in the foreground but Magpie still doesn't upscale it, unless I use the shortcut to force the window to upscale. Is there an ETA for this new feature to be released? Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants