Skip to content
This repository was archived by the owner on Feb 26, 2025. It is now read-only.

2986 fix styles#1015

Merged
dhaneshnm merged 6 commits into
1.7.0-M3from
2986-Fix-styles
Jan 6, 2022
Merged

2986 fix styles#1015
dhaneshnm merged 6 commits into
1.7.0-M3from
2986-Fix-styles

Conversation

@dhaneshnm

Copy link
Copy Markdown
Contributor

Fixes # BlueBrain/nexus/issues/2986

Description

How has this been tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added necessary unit and integration tests.
  • I have added screenshots (if applicable), in the comment section.

- Remove form logic.
- Rmeove style from form item.
@dhaneshnm dhaneshnm requested review from nicwells and smitfire January 5, 2022 13:56
@dhaneshnm dhaneshnm changed the base branch from main to 1.7.0-M3 January 5, 2022 13:56
@codecov-commenter

codecov-commenter commented Jan 5, 2022

Copy link
Copy Markdown

Codecov Report

❗ No coverage uploaded for pull request base (1.7.0-M3@034f391). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             1.7.0-M3    #1015   +/-   ##
===========================================
  Coverage            ?   65.95%           
===========================================
  Files               ?       21           
  Lines               ?      611           
  Branches            ?      126           
===========================================
  Hits                ?      403           
  Misses              ?      208           
  Partials            ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 034f391...382f4b0. Read the comment docs.

@nicwells nicwells left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, looks good. One very minor comment

Comment thread src/subapps/admin/components/ViewForm/SparqlQueryForm.tsx Outdated
@nicwells nicwells self-requested a review January 6, 2022 09:27
@dhaneshnm dhaneshnm merged commit d619c4a into 1.7.0-M3 Jan 6, 2022
@dhaneshnm dhaneshnm deleted the 2986-Fix-styles branch January 6, 2022 10:28
smitfire added a commit that referenced this pull request Jan 10, 2022
…to 2938-nums

* '2938-nums' of https://github.com/BlueBrain/nexus-web:
  2986 fix styles (#1015)
  Add redirect params to login call back (#1014)
  2644 allow user to select search config (#1011)
  Rewrite useLocalStorage hook and make use of (#1012)
dhaneshnm pushed a commit that referenced this pull request Jan 10, 2022
* Fix styles for sparql-editor

- Remove form logic.
- Remove style from form item.

save changes

Fix login

somehwat works

somehwat works2

somehwat works2
dhaneshnm pushed a commit that referenced this pull request Mar 11, 2022
* Fix styles for sparql-editor

- Remove form logic.
- Remove style from form item.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants