Migrate Organizations to Cats Effect #4360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imsdu
reviewed
Oct 12, 2023
| ) => | ||
| OrganizationsImpl( | ||
| scopeInitializations, | ||
| config.organizations, | ||
| xas | ||
| )(clock, uuidF) | ||
| )(clock, uuidF, contextShift) |
There was a problem hiding this comment.
Not related to this PR but it feels that we should rework how we run those scope initialization.
It is not up to orgs/projects to know how they should be run.
One other thing is that it introduces circular dependencies between orgs and the modules with the scope initialization implementations
shinyhappydan
force-pushed
the
organizations-ce-migration
branch
2 times, most recently
from
8252158
to
e744625
Compare
shinyhappydan
force-pushed
the
organizations-ce-migration
branch
from
e744625
to
bf71fa0
Compare
olivergrabinski
approved these changes
Oct 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4332