Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug while importing files with special characters in name #4983

Merged
merged 2 commits into from
May 16, 2024
Merged

Fix bug while importing files with special characters in name #4983

merged 2 commits into from
May 16, 2024

Conversation

imsdu
Copy link
Contributor

@imsdu imsdu commented May 16, 2024

No description provided.

dantb
dantb approved these changes May 16, 2024
View reviewed changes
Copy link
Contributor

@dantb dantb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe accepting a new type in the client could enforce that paths are decoded correctly, so we don't have to remember at every call site (could also have convenience syntax)

@imsdu
Copy link
Contributor Author

imsdu commented May 16, 2024

Maybe accepting a new type in the client could enforce that paths are decoded correctly, so we don't have to remember at every call site (could also have convenience syntax)

That is what I am thinking too, I will open a ticket about it

@imsdu imsdu merged commit 30848be into BlueBrain:master May 16, 2024
6 checks passed
@imsdu imsdu deleted the test-encoding-filenames-import branch May 16, 2024 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dantb dantb dantb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@imsdu @dantb