Add synaptome properties, examples and tests #5119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bilalesi
reviewed
Aug 23, 2024
tests/src/test/scala/ch/epfl/bluebrain/nexus/tests/kg/SearchConfigIndexingSpec.scala
Show resolved
Hide resolved
tests/src/test/scala/ch/epfl/bluebrain/nexus/tests/kg/SearchConfigIndexingSpec.scala
Show resolved
Hide resolved
|
LGTM 👍 |
bilalesi
approved these changes
Aug 23, 2024
|
For the merging on gitlab, usually @imsdu does that part |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added the properties requested, just be aware that they are indexed with different names:
SingleNeuronSynaptome:
used -> .singleNeuronSynaptome.memodel,
seed -> .singleNeuronSynaptome.seed
SynaptomeSimulation:
used -> synaptomeSimulation.synaptome
injectionLocation -> synaptomeSimulation.injectionLocation
recordingLocation -> synaptomeSimulation.recordingLocation