add SPARSE solver to SympySolver - resolves #26 #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lkeegan
added
enhancement
pramodk
reviewed
Mar 6, 2019
-for case when ODEs are coupled & linear: -constructs backwards Euler linear system -solves linear system by Gaussian elimination -declares required new local variables in each solve block -replaces ODEs (and adds new statements) with explicit solution of backwards Euler -optionally finds CSE (common sub expressions) -visitor logic altered to deal with each solve block separately -added --cse flag to sympy options to enable CSE generation -added -v,--verbose flag to enable debug logger output -updated README with the new flags -TODO: check it actually works (!), add tests Change-Id: I4dff1e5627be515c9c40d17a536d44cc679259af
lkeegan
force-pushed
the
coupled_linear_odes
branch
from
5580dd8
to
8b81e01
Compare
ohm314
suggested changes
Mar 7, 2019
Change-Id: I533bb8430800c200c398a11e3079011a889dfcbd
ohm314
approved these changes
Mar 7, 2019
Change-Id: I1c8c74485d13ac8515059d973593dd9923520587
Change-Id: I4fb63c358b01e2cad0461f661b40108e3564c075
pramodk
force-pushed
the
coupled_linear_odes
branch
from
42b400f
to
81843b1
Compare
lkeegan
added a commit
that referenced
this pull request
Mar 8, 2019
For case when ODEs are coupled & linear: - constructs backwards Euler linear system - solves linear system by Gaussian elimination - declares required new local variables in each solve block - replaces ODEs (and adds new statements) with explicit solution of backwards Euler - optionally finds CSE (common sub expressions) - visitor logic altered to deal with each solve block separately - added --cse flag to sympy options to enable CSE generation - added -v,--verbose flag to enable debug logger output - updated README with the new flags - TODO: tests and integration tests, see #40 Resolves #26
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-for case when ODEs are coupled & linear:
-constructs backwards Euler linear system
-solves linear system by Gaussian elimination
-declares required new local variables in each solve block
-replaces ODEs (and adds new statements) with explicit solution of backwards Euler
-optionally finds CSE (common sub expressions)
-visitor logic altered to deal with each solve block separately
-added --cse flag to sympy options to enable CSE generation
-added -v,--verbose flag to enable debug logger output
-updated README with the new flags
-TODO: check it actually works (!), add tests