Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Check Bech32 uppercase address #2911

Merged
merged 3 commits into from
May 19, 2021

Conversation

jaonoctus
Copy link
Contributor

Fix #2910

image

Copy link
Member

@Overtorment Overtorment left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also, missing basic unit tests, for both bech32 HD (BIP84 & aezeed, and I think electrumFormaSeed) and bech32 single-address

class/wallets/abstract-hd-electrum-wallet.js Outdated Show resolved Hide resolved
class/wallets/abstract-hd-electrum-wallet.js Show resolved Hide resolved
@jaonoctus jaonoctus force-pushed the bugfix/check-bech32-address branch 2 times, most recently from 3263b65 to 6b0a2ff Compare May 17, 2021 20:11
@jaonoctus jaonoctus force-pushed the bugfix/check-bech32-address branch from 6b0a2ff to 755900e Compare May 17, 2021 20:13
@Overtorment Overtorment merged commit 79f2194 into BlueWallet:master May 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check Address from Samourai
4 participants