Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds more laser gun subtypes #73

Merged
merged 2 commits into from
Dec 15, 2018
Merged

Adds more laser gun subtypes #73

merged 2 commits into from
Dec 15, 2018

Conversation

ike709
Copy link
Contributor

@ike709 ike709 commented Dec 14, 2018

No description provided.

monster860
monster860 requested changes Dec 15, 2018
View reviewed changes
code/modules/projectiles/guns/energy/laser.js Outdated
"EnergyGun": {
charge_x_offset: 2/32,
selfcharge: true,
clumsy_check: false,
Copy link
Member

@monster860 monster860 Dec 15, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should go in Gun not EnergyGun

@monster860
Copy link
Member

You should remove charge_x_offset thingies because they do nothing if shaded_charge is set to true. It's used for appending offsets to each of the charge sections if they are all seperate overlays, which is not the case for laser guns.

@monster860 monster860 merged commit 6e9449d into Bluespess:master Dec 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@monster860 monster860 monster860 approved these changes

Assignees
No one assigned
Labels
Bulk Port Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ike709 @monster860