Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Veteris Unathi Improvements, or Why the fuck did I even add Veteris Unathi #512

Merged
merged 1 commit into from
Mar 9, 2020

Conversation

BurgerLUA
Copy link
Contributor

Ok so now the Unathi can wear most suits, however since NanoTrasen doesn't really give a fuck about your species, you have to apply a unathi helmet and then a human body for you to wear it.

Also Veteris Unathi can no longer wear human gloves, and must use modified gloves.

This PR has drained me.

@Sparrowbird611
Copy link
Contributor

.....…...………..I've really gotta ask.

Is there a reason why you didn't just make them use the unathi suit options, instead of both a human suit and an unathi helmet? This seems needlessly tedious, even by suit cycling standards. Also, I kind of assumed the cycling was more for the tails, not the legs.

@BurgerLUA
Copy link
Contributor Author

.....…...………..I've really gotta ask.

Is there a reason why you didn't just make them use the unathi suit options, instead of both a human suit and an unathi helmet? This seems needlessly tedious, even by suit cycling standards. Also, I kind of assumed the cycling was more for the tails, not the legs.

Because Veteris Unathi have a closer bodytype to humans than Unathi.

@Sparrowbird611
Copy link
Contributor

Kind of seems needlessly painful to need to only swap the suit and not the helmet, as well as rather awkward, since most people would assume you'd need to have both an unathi helmet and an unathi suit for this to work, and not some confusion where you need a human body and an unathi helmet. I think it'd be better off keeping it consistent with either using a full unathi suit or a full human suit, but this is your PR so.

@MarinaGryphon
Copy link
Contributor

Personally, I think the mismatched suit/helmet stuff is actually really cool and unique. Code-wise this PR seems solid, I think.

Copy link
Contributor

@MarinaGryphon MarinaGryphon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Massively out of scope and incorrectly enforces a nonexistent style guideline. Merge-ready.

@MarinaGryphon MarinaGryphon merged commit 10ec966 into BoHBranch:dev Mar 9, 2020
@BurgerLUA BurgerLUA added this to the April 1st, 2020 milestone Mar 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants