Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #456: [FR] Handle ar-mot and ar-terme #468

Merged
merged 1 commit into from
Dec 17, 2020
Merged

Conversation

lasconic
Copy link
Collaborator

scripts/lang/fr/__init__.py Outdated Show resolved Hide resolved
scripts/lang/fr/arabiser.py Outdated Show resolved Hide resolved
@lasconic
Copy link
Collaborator Author

lasconic commented Dec 11, 2020

FYI I didn't test this on kobo at all... I have no idea how arabic is rendered on kobo, even with a Unicode font.

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Dec 11, 2020

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 1.80%.

Quality metrics Before After Change
Complexity 13.50 🙂 14.50 🙂 1.00 👎
Method Length 379.33 ⛔ 387.67 ⛔ 8.34 👎
Working memory 143.52 ⛔ 137.82 ⛔ -5.70 👍
Quality 34.35% 😞 32.55% 😞 -1.80% 👎
Other metrics Before After Change
Lines 755 762 7
Changed files Quality Before Quality After Quality Change
scripts/lang/fr/init.py 34.35% 😞 32.55% 😞 -1.80% 👎

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
scripts/lang/fr/init.py last_template_handler 22 😞 210 ⛔ 18 ⛔ 27.55% 😞 Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Let us know what you think of it by mentioning @sourcery-ai in a comment.

@BoboTiG
Copy link
Owner

BoboTiG commented Dec 11, 2020

I will be able to test and take a screenshot.

@BoboTiG
Copy link
Owner

BoboTiG commented Dec 15, 2020

Sorry for the delay, I will test it tomorrow for sure :)

@BoboTiG BoboTiG merged commit 049a593 into BoboTiG:master Dec 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FR] Handle ar-mot and ar-terme
2 participants