Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StubBroker vs RedisBroker+redislite #58

Closed
rpkilby opened this issue Apr 9, 2018 · 6 comments
Closed

StubBroker vs RedisBroker+redislite #58

rpkilby opened this issue Apr 9, 2018 · 6 comments
Assignees
Labels

Comments

@rpkilby
Copy link
Contributor

rpkilby commented Apr 9, 2018

During testing, what are the practical differences between the StubBroker and the RedisBroker+redislite?

@Bogdanp Bogdanp self-assigned this Apr 10, 2018
@Bogdanp
Copy link
Owner

Bogdanp commented Apr 10, 2018

I've never used redislite (though it looks pretty cool!) so I wouldn't really know. The biggest difference would be that the stub broker doesn't have any dependencies, but they should both behave the same.

I don't think I'd want to replace the stub broker with that combination, however, because it doesn't feel right to force someone who, for example, only uses the RMQ broker to also install Redis if he/she doesn't need it.

@rpkilby
Copy link
Contributor Author

rpkilby commented Apr 10, 2018

Definitely agree - the StubBroker is a suitable testing alternative for RMQ users. Mostly just wanted to check if the StubBroker had any behavior differences or additional testing features that I would otherwise miss out on by using redislite.

@Bogdanp Bogdanp closed this as completed Apr 10, 2018
@rpkilby
Copy link
Contributor Author

rpkilby commented Apr 10, 2018

Ah - the RedisBroker does not have the flush and flush_all methods.

@Bogdanp
Copy link
Owner

Bogdanp commented Apr 10, 2018

Right, but it doesn't really need them since you can just flush Redis directly.

@rpkilby
Copy link
Contributor Author

rpkilby commented Apr 10, 2018

That would presume that the user is familiar with redis and knows how to flush dramatiq's queues. Also, from a testing perspective the consistency would be helpful, as switching brokers wouldn't require rewriting how the broker is flushed.

@Bogdanp
Copy link
Owner

Bogdanp commented Apr 10, 2018

Makes sense. I opened #62 to track that as an enhancement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants