Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to test api with Swagger UI to upload file/s #23

Closed
gurvindersingh opened this issue Nov 5, 2018 · 6 comments
Closed

Ability to test api with Swagger UI to upload file/s #23

gurvindersingh opened this issue Nov 5, 2018 · 6 comments
Assignees
Labels

Comments

@gurvindersingh
Copy link

@gurvindersingh gurvindersingh commented Nov 5, 2018

As discussed on the reddit thread there is issue with current swagger api generation. It does shows the content type option as multipart/form-data but doesn't give option to browse and upload the file.

It might be related to the missing format: binary option as mentioned in https://swagger.io/docs/specification/describing-request-body/file-upload/

What version of molten are you using?

0.7.1

@gurvindersingh
Copy link
Author

@gurvindersingh gurvindersingh commented Nov 7, 2018

@Bogdanp in case if you want to reproduce the issue, this is the repo which has all the code https://github.com/gurvindersingh/mlapp simply run it using gunicorn app:app and its /predict route.

Let me know if you need any more info to get this one fixed.

@Bogdanp Bogdanp self-assigned this Nov 10, 2018
@Bogdanp Bogdanp added the bug label Nov 10, 2018
@Bogdanp
Copy link
Owner

@Bogdanp Bogdanp commented Nov 10, 2018

Thanks! This should be fixed in 0.7.2, but you're going to have to select the multipart mime type from the UI.

@Bogdanp Bogdanp closed this Nov 10, 2018
@gurvindersingh
Copy link
Author

@gurvindersingh gurvindersingh commented Nov 11, 2018

It seems the UI still doesn't show the upload file option. Even when selected the correct encoding. See the pic below from the upload example app in examples directory.
screenshot_2018-11-11 molten docs

@Bogdanp
Copy link
Owner

@Bogdanp Bogdanp commented Nov 12, 2018

@gurvindersingh you have to click "Try it out".

@gurvindersingh
Copy link
Author

@gurvindersingh gurvindersingh commented Nov 12, 2018

@Bogdanp Sorry for such a silly mistake. Thanks it works :)

@Bogdanp
Copy link
Owner

@Bogdanp Bogdanp commented Nov 12, 2018

No worries!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants