Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full PDF Wrapper #1270

Open
recklessnl opened this issue Feb 9, 2019 · 25 comments
Open

Full PDF Wrapper #1270

recklessnl opened this issue Feb 9, 2019 · 25 comments

Comments

@recklessnl
Copy link

recklessnl commented Feb 9, 2019

Describe the feature you'd like
Bookstack is a Wiki-like app, a perfect place to store manuals. A ton of manuals on the internet are stored as PDFs. It would be so much easier if Bookstack had native PDF Wrapper support enabled for users to instantly load the PDF file within the Bookstack page.

Describe the benefits this feature would bring to BookStack users
Pretty self-explanatory, it makes Bookstack even more useable for small businesses or families.

Additional context
Currently you can only download PDFs to your PC. There are other docker apps like Grocy who have full PDF wrapper support and it really makes it so much easier. Really hope this can get added.

@ssddanbrown
Copy link
Member

Hi @recklessnl,
Thanks for the request.

This seems very similar to #705, Do you see this issue as different to that one or can I close this as a duplicate?

@recklessnl
Copy link
Author

It's different, because we shouldn't want a 'preview', we should have a full wrapper that enables users to directly 'stream' the PDF file in question. This way you can embed the PDFs directly into the overall Bookstack page, alongside all the other tools you are currently have implemented. It's not so much a preview as a fully functioning PDF embed / wrapper. I can't think of any downside to this.

@ssddanbrown
Copy link
Member

Ah, Okay, Thanks for confirming the difference.

I can't think of any downside to this.

  • Web PDF renders can have varying and heavy performance due to the complexities in rendering PDFS.
  • Web PDF renders can often have quirks and not fully support all features of a PDF.
  • This would be extra functionality to implement & maintain, Especially if built into the editors, Using up more maintainer time.
  • This could encorouge users leaving content in PDF format, instead of page content, where it becomes much harder for BookStack to index for search/discovery and revision tracking.

@recklessnl
Copy link
Author

recklessnl commented Feb 14, 2019

  1. A PDF wrapper is optional feature users can add to their pages. If it doesn't perform up to standard, they can use the current system.
  2. Same as above, although I have to say I love the one Grocy is using. Works fine for my needs. The point isn't to have a fully functional PDF editor anyway, it should be for reading.
  3. Can't comment on this, all I can say is it would make bookstack a lot better and more useable
  4. So what? More power to the users. I want some pages to be just one big PDF manual page. Who are you to tell me how to use it? Again, you don't HAVE to use it if you don't want it. Besides, copying a full PDF manual to pictures or a format that bookstack can read is tedious as ****. Much better to just have a PDF reader / wrapper and make it easy for everyone.

Must have feature for me.

@ssddanbrown
Copy link
Member

4. So what? More power to the users. I want some pages to be just one big PDF manual page. Who are you to tell me how to use it? Again, you don't HAVE to use it if you don't want it.

This may be the case for your usage but it's not always up to users how they are supposed to use the system. We have to consider the wider view of how BookStack may be used. In a lot of instances BookStack would have been implemented to ensure documentation is standardised and indexed but adding this would work against that.

Must have feature for me.

It looks like some users have had luck implementing something similar to what you're asking for in #705 otherwise it may be a while before something like this is officially supported.

@danielsagostinho
Copy link

Actually, I was searching for something like this. Before your app, I've done manuals and converted them to PDF, would be nice to import material that is already done, and not do it again in the editor.

The attachment doesn't really "work", since most people see a blank page and don't check the attachments.

@xthursdayx
Copy link

I love Bookstack in general, but I am also desperate to see this feature added. In my use case, 99% of my entries will still be standard Bookstack markdown pages, but I would like to be able to host, link to, and view pdf hardware manuals from within my books.

@recklessnl
Copy link
Author

Ping @ssddanbrown any update on this?

@ssddanbrown
Copy link
Member

@recklessnl No, not at this time.

@sargrvb
Copy link

sargrvb commented Sep 25, 2020

I'm also looking for a PDF cloud viewer of sorts. I love using Home Assistant and have been trying to integrate Grocy into my flow. Using something more specific like BookStack or Calibre seems ideal though. Please reconsider adding this feature some time in the future.

@Wookbert
Copy link

+1 for inline PDF viewing.

Same approach here: Aggregating the (PDF) manuals for all household appliances etc. we own in BookStack.

@TheTwist76
Copy link

+1

@seventinth
Copy link

+1 for the new month. surprised this isn't already built in.

@sprklinginfo
Copy link

sprklinginfo commented May 12, 2021

I'd like this feature as well. It is annoying to have to download the pdf file in order to view it. Inspired by the information in a similar request, here is my workaround to solve this issue before any official supports released. Please see my comment here: #705 (comment)

@ssddanbrown
Copy link
Member

Just a note on this, Within BookStack v21.05.2 it's now possible to open up attachments in an "inline" (Not forced download) via Ctrl+Click of the attachment (Or Cmd+click on Mac). Alternatively, an attachment link of this type can be manually formed by adding an ?open=true query parameter to the link.

The above may make it easier to implement workarounds to achieve embedding. You can kind of get something going by using one of these "inline" links within an iframe, added via the "media" button of the WYSIWYG editor. You might need to get some custom styles going though to control iframe sizing.

@lewisstancer
Copy link

+1. I would be quite happy with just a PDF viewer with a customisable fixed height.

I can use HTML embed code like this to place a viewer into a custom HTML page but this doesn't appear to work on BookStack

<embed src="https://www.w3.org/WAI/ER/tests/xhtml/testfiles/resources/pdf/dummy.pdf" type="application/pdf" width="100%" height="500px" />

@lewisstancer
Copy link

I have a way to do this on my own system. You upload the attachment and then use the embed code I pasted above. Change the URL to the URL of the uploaded attachment, add ?open=true to the end and voila! Seems to work without any issue

@ssddanbrown
Copy link
Member

@lewisstancer If you hold down Ctrl when clicking the attachment you'll get the link without having to manually append the query string yourself.

@alabastrowa
Copy link

I just started using the bookstack. Unfortunately, the method described above with displaying pdf after pressing ctrl does not work. Am I doing something wrong or do I need to change something? All I can do is download the file.

@ChristophTek
Copy link

I am also +1 for this, My line of work we have many manuals which for ease of storage would be great on Bookstack. We have the compute power so that's not a concern. I would agree with @recklessnl it should be an opt-in function.

@zeus1999
Copy link

+1 it would be an very helpfull feature for me

works good, but its not possible for an dynamic height or an 100% height for the file

@dockrbyter
Copy link

+1

@ssddanbrown ssddanbrown mentioned this issue Jul 20, 2022
1 task
@helson22 helson22 mentioned this issue Oct 5, 2022
1 task
@FlimFlam
Copy link

+1

@homeztead
Copy link

+++++ 1
Please make it easier for us non-tech savvy users....
BookStack is truly a great product and this would elevate it to be closer to Supreme status.
Thank you for what you do.

@biziosan
Copy link

+++++1
I just discovered Bookstack, and I love it. Thank you for your hard work! However, the thing that is stopping us from adopting it is the lack of an integrated PDF viewer. Since PDF is everywhere and will not go away any time soon, I was expecting it to be a very basic feature. Also, Mozilla has implemented it for you. There is no need to maintain it. Please make this feature available!!!

@ssddanbrown ssddanbrown mentioned this issue Jun 19, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests