-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Full PDF Wrapper #1270
Comments
Hi @recklessnl, This seems very similar to #705, Do you see this issue as different to that one or can I close this as a duplicate? |
It's different, because we shouldn't want a 'preview', we should have a full wrapper that enables users to directly 'stream' the PDF file in question. This way you can embed the PDFs directly into the overall Bookstack page, alongside all the other tools you are currently have implemented. It's not so much a preview as a fully functioning PDF embed / wrapper. I can't think of any downside to this. |
Ah, Okay, Thanks for confirming the difference.
|
Must have feature for me. |
This may be the case for your usage but it's not always up to users how they are supposed to use the system. We have to consider the wider view of how BookStack may be used. In a lot of instances BookStack would have been implemented to ensure documentation is standardised and indexed but adding this would work against that.
It looks like some users have had luck implementing something similar to what you're asking for in #705 otherwise it may be a while before something like this is officially supported. |
Actually, I was searching for something like this. Before your app, I've done manuals and converted them to PDF, would be nice to import material that is already done, and not do it again in the editor. The attachment doesn't really "work", since most people see a blank page and don't check the attachments. |
I love Bookstack in general, but I am also desperate to see this feature added. In my use case, 99% of my entries will still be standard Bookstack markdown pages, but I would like to be able to host, link to, and view pdf hardware manuals from within my books. |
Ping @ssddanbrown any update on this? |
@recklessnl No, not at this time. |
I'm also looking for a PDF cloud viewer of sorts. I love using Home Assistant and have been trying to integrate Grocy into my flow. Using something more specific like BookStack or Calibre seems ideal though. Please reconsider adding this feature some time in the future. |
+1 for inline PDF viewing. Same approach here: Aggregating the (PDF) manuals for all household appliances etc. we own in BookStack. |
+1 |
+1 for the new month. surprised this isn't already built in. |
I'd like this feature as well. It is annoying to have to download the pdf file in order to view it. Inspired by the information in a similar request, here is my workaround to solve this issue before any official supports released. Please see my comment here: #705 (comment) |
Just a note on this, Within BookStack v21.05.2 it's now possible to open up attachments in an "inline" (Not forced download) via Ctrl+Click of the attachment (Or Cmd+click on Mac). Alternatively, an attachment link of this type can be manually formed by adding an The above may make it easier to implement workarounds to achieve embedding. You can kind of get something going by using one of these "inline" links within an iframe, added via the "media" button of the WYSIWYG editor. You might need to get some custom styles going though to control iframe sizing. |
+1. I would be quite happy with just a PDF viewer with a customisable fixed height. I can use HTML embed code like this to place a viewer into a custom HTML page but this doesn't appear to work on BookStack
|
I have a way to do this on my own system. You upload the attachment and then use the embed code I pasted above. Change the URL to the URL of the uploaded attachment, add |
@lewisstancer If you hold down |
I just started using the bookstack. Unfortunately, the method described above with displaying pdf after pressing ctrl does not work. Am I doing something wrong or do I need to change something? All I can do is download the file. |
I am also +1 for this, My line of work we have many manuals which for ease of storage would be great on Bookstack. We have the compute power so that's not a concern. I would agree with @recklessnl it should be an opt-in function. |
+1 it would be an very helpfull feature for me works good, but its not possible for an dynamic height or an 100% height for the file |
+1 |
+1 |
+++++ 1 |
+++++1 |
Describe the feature you'd like
Bookstack is a Wiki-like app, a perfect place to store manuals. A ton of manuals on the internet are stored as PDFs. It would be so much easier if Bookstack had native PDF Wrapper support enabled for users to instantly load the PDF file within the Bookstack page.
Describe the benefits this feature would bring to BookStack users
Pretty self-explanatory, it makes Bookstack even more useable for small businesses or families.
Additional context
Currently you can only download PDFs to your PC. There are other docker apps like Grocy who have full PDF wrapper support and it really makes it so much easier. Really hope this can get added.
The text was updated successfully, but these errors were encountered: