Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug in documentation - /dev/docs /visual-theme-system.md & corresponding YouTube video #4998

Closed
mkduew opened this issue May 12, 2024 · 1 comment
Labels
Milestone

Comments

@mkduew
Copy link

mkduew commented May 12, 2024

Describe the Bug

under "Customizing Text Content" it says:

"Folders with PHP translation files placed in a themes/<theme_name>/lang folder will override translations defined within the resources/lang folder."

That is not correct. Correct is:

"Folders with PHP translation files placed in a themes/<theme_name>/lang folder will override translations defined within the lang folder."

Also it is described wrong in the corresponding YouTube video = [Customize BookStack using the Visual Theme System](https://youtu.be/gLy_2GBse48?si=H4-zKESyugPGuqlH&t=291)

Steps to Reproduce

  1. see documentation
  2. see YouTube video

Expected Behaviour


Screenshots or Additional Context

No response

Browser Details

No response

Exact BookStack Version

24.05

@mkduew mkduew changed the title bug in documentation - /dev/docs /visual-theme-system.md bug in documentation - /dev/docs /visual-theme-system.md & corresponding YouTube video May 12, 2024
@ssddanbrown ssddanbrown added this to the v24.05.1 milestone May 12, 2024
@ssddanbrown
Copy link
Member

Thanks for raising @mkduew, I agree the docs should be updated. I'd consider the video (and all our videos) a point-in-time kind of thing though so I won't attempt to alter that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

2 participants