Skip to content

added copy button for codeblock#527

Closed
ZeroX-DG wants to merge 1 commit intoBoostIO:masterfrom
ZeroX-DG:copy-button
Closed

added copy button for codeblock#527
ZeroX-DG wants to merge 1 commit intoBoostIO:masterfrom
ZeroX-DG:copy-button

Conversation

@ZeroX-DG
Copy link
Copy Markdown
Member

@ZeroX-DG ZeroX-DG commented Jul 8, 2020

This added support for copy button for markdown codeblock

Fixed #315

ss


IssueHunt Summary

Referenced issues

This pull request has been submitted to:


@ZeroX-DG ZeroX-DG added the awaiting review ❇️ Pull request is awaiting a review. label Jul 8, 2020
@Rokt33r
Copy link
Copy Markdown
Member

Rokt33r commented Jul 21, 2020

Nice try. But the approach isn't good. I'd like to replace code fences rather than injecting class name just for the button. The AST tree should be pure and extra UI must be implemented when we rendering. I'll redo it!

@Rokt33r Rokt33r closed this Jul 21, 2020
@Rokt33r Rokt33r reopened this Jul 21, 2020
@Rokt33r
Copy link
Copy Markdown
Member

Rokt33r commented Jul 21, 2020

I'll just continue working in this pr.

@Rokt33r Rokt33r added this to the v0.7.1 milestone Jul 21, 2020
@Rokt33r Rokt33r removed this from the v0.7.1 milestone Jul 26, 2020
@Rokt33r
Copy link
Copy Markdown
Member

Rokt33r commented Jul 26, 2020

Resolved by #560

@Rokt33r Rokt33r closed this Jul 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting review ❇️ Pull request is awaiting a review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Copy button missing on markdown code snippets

2 participants