Added feature to export as PDF

[billyLumberjack]

---

IssueHunt Summary

Referenced issues

This pull request has been submitted to:

• #243: Re-Add Export as PDF option to the export list

---

[CLAassistant]

All committers have signed the CLA.

[ZeroX-DG]

Thank you for the PR, can you give us some comparison on why you think jsPDF should be used instead of the native print to PDF feature of chromium?

[billyLumberjack]

Hello , sorry for the poor level of information attached to the PR.
Honestly I am not aware of a native print to PDF method, are you referring to this?
https://www.w3schools.com/jsref/met_win_print.asp

At the moment jspdf to me looks the solution which better fits the already written code, giving also the support to get the "blob"

Thanks for your feedback,
I remain available for any improvement

[ZeroX-DG]

Hmm, that's actually not a bad reason, this will have consistency for the whole app because printing may be different between web and electron version. I'll ask @Rokt33r for his thought on this

[Rokt33r]

Great work! I'll review this tonight.

[Rokt33r]

Exporting as PDF doesn't work well. It doesn't keep css style.

[billyLumberjack]

Exporting as PDF doesn't work well. It doesn't keep css style.

Thanks for the feedback, the pdf exported style is the same as the html one. So it should be corrected even this one right ?

[Rokt33r]

@billyLumberjack
5fb9083
It just moves the type dep to dev deps. You need to install jspdf. @types/jspdf only has type defs not real code.

Jspdf seems to apply styles in the html. But styles for code fences and math blocks are from external css file. Please check those blocks are styled properly in a exported pdf file.

[ZeroX-DG]

@billyLumberjack can you fix the conflict please?

[ZeroX-DG]

@billyLumberjack ping!

[Rokt33r]

I'm going to take over this task

[billyLumberjack]

@billyLumberjack
5fb9083
It just moves the type dep to dev deps. You need to install jspdf. @types/jspdf only has type defs not real code.

Jspdf seems to apply styles in the html. But styles for code fences and math blocks are from external css file. Please check those blocks are styled properly in a exported pdf file.

Hello, actually jspdf is not including the style, I am trying with html2canvas but getting document does not have window attached

[Rokt33r]

@billyLumberjack I'm going to do this later. If you want to continue trying, please try it! I'll let you know when I can actually start working on this.

[mcmxcdev]

Can you not simply use the electron native method for this:
https://www.electronjs.org/docs/api/web-contents#contentsprinttopdfoptions ?

Then you can avoid an extra 3rd party dependency.

[Rokt33r]

This will be resolved in #652