Allow preview area to scroll past end of file #1480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sosukesuzuki
requested changes
Jan 30, 2018
There was a problem hiding this comment.
Now, If I switch scrollPastEnd of preview in Preference, actually it is not switched.
Because you not pass config.preview.scrollEnd as props to MarkdownPreview in MarkdownEditor.js.
Actually, MarkdownPreview has scrollPastEnd as props. However, It is config.editor.scrollPastEnd.
So, please pass config.preview.scrollPastEnd as props to MarkdownPreview in MarkdownEditor.js, like below.
Now
<MarkdownPreview
・・・
scrollPastEnd={config.editor.scrollPastEnd}
・・・
/>Please
<MarkdownPreview
・・・
scrollPastEnd={config.preview.scrollPastEnd}
・・・
/>
kazup01
added
awaiting changes 🖊️
|
@sosukesuzuki not sure how that option got there but I updated it to correctly use |
|
Thanks for your fix! |
sosukesuzuki
approved these changes
Jan 31, 2018
|
Awesome! Thank you @allejo 😄 |
kazup01
added
next release (v0.8.21)
and removed
awaiting changes 🖊️
|
Thank you both! 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With regards to #1471... Here's a PR from a complete novice when it comes to the Electron and React world, hope it's not too bad. I'm open to learning to the correct way of doing things if you'd be so kind as to point me in the right direction. Anyhow, this worked for me