Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added zoom in & zoom out window feature #1969

Merged
merged 1 commit into from
Jun 8, 2018

Conversation

ZeroX-DG
Copy link
Member

@ZeroX-DG ZeroX-DG commented May 24, 2018

The zoom in & zoom out window feature has been requested here: #1907

Now, users can zoom in and zoom out the boostnote window using ctrl + '+' and ctrl + '-', respectively.

I have tested this feature on linux mint, I think it'll work on window too (I'm not very sure) and I haven't tested on mac (for obvious reason, I'm poor and can't afford a macbook 😄 )

@kazup01 kazup01 added the awaiting review ❇️ Pull request is awaiting a review. label May 25, 2018
@sosukesuzuki
Copy link
Member

I tested on macOS, It worked correctly:+1:

@Rokt33r
Copy link
Member

Rokt33r commented May 28, 2018

@ehhc How do you think? Does it look reasonable for Windows?
And, if you have spare time, could you check this work well in Windows?

@ehhc
Copy link
Contributor

ehhc commented May 28, 2018

@Rokt33r for me it works using windows as well.
At first look i would also say it looks good. But at a second glance:
Why is it zooming the whole UI? wouldn't it be better if only the editor/preview would be zoomed in?
At the other hand: the zoom-button already available does exactly the same.. so maybe that is the intendet feature.. I'm just not sure about that?
Should this feature zoom the whole UI? If yes: then it works for me (on windows) as well (as i said :) )

@sosukesuzuki sosukesuzuki added the discussion 💬 Issue concerns a discussion. label Jun 1, 2018
@sosukesuzuki
Copy link
Member

umm...
I think it is necessary to zoom the whole UI.
I want the NoteList to be zoomed in the same as editor/preview...

@ZeroX-DG
Copy link
Member Author

ZeroX-DG commented Jun 2, 2018

Yeah, I agree that sometime, I want to zoom the note list and the setting modal as the font size is a bit too small for me. I would love to have a whole UI zoom feature like that.

@sosukesuzuki
Copy link
Member

@ehhc what do you think?

@ehhc
Copy link
Contributor

ehhc commented Jun 6, 2018

as i said, the feature works. and according to @ZeroX-DG i does what it should do :)

@Rokt33r
Copy link
Member

Rokt33r commented Jun 8, 2018

@sosukesuzuki @ehhc Hmm... I was asking about the keybinding for Windows!!

@Rokt33r Rokt33r merged commit c30957f into BoostIO:master Jun 8, 2018
@Rokt33r Rokt33r added next release (v0.11.6) and removed discussion 💬 Issue concerns a discussion. awaiting review ❇️ Pull request is awaiting a review. labels Jun 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants