Add Wakatime integration #2923

LuisReinoso · 2019-03-13T03:39:38Z

Description

Add Wakatime support to track time spend writing in Boostnote.

Result on wakatime.

Issue fixed

#2810

Type of changes

⚪ Bug fix (Change that fixed an issue)
⚪ Breaking change (Change that can cause existing functionality to change)
⚪ Improvement (Change that improves the code. Maybe performance or development improvement)
❌ Feature (Change that adds new functionality)
⚪ Documentation change (Change that modifies documentation. Maybe typo fixes)

Checklist:

❌ My code follows the project code style
⚪ I have written test for my code and it has been tested
❌ All existing tests have been passed
❌ I have attached a screenshot/vido to visualize my change if possible

…ge from Markdown to Snippet BoostIO#2810

ZeroX-DG · 2019-05-04T23:33:30Z

Can you fix the conflict? And also check if the wakatime-cli is installed on the user system? Maybe display a small alert saying, the wakatime-cli is not found, please install it.

LuisReinoso · 2019-05-06T18:46:12Z

Sure, I will do this weekend.

ZeroX-DG · 2020-01-29T23:43:48Z

@LuisReinoso ping:) Do you still interested in this PR?

LuisReinoso · 2020-01-30T01:26:37Z

Oh oh oh.. I was forgot it.. Yes

ZeroX-DG · 2020-01-30T02:24:41Z

Haha no worries, glad you can contribute this feature 👍

ZeroX-DG · 2020-04-23T04:45:57Z

@LuisReinoso ping

ZeroX-DG · 2020-05-07T13:22:03Z

@LuisReinoso ping!

LuisReinoso · 2020-05-08T22:18:31Z

Something strange is happen. Why is fetching your this repo instead of my work?

I have a blocker.

Lint on my side

Lint on CI

ZeroX-DG · 2020-05-09T03:49:15Z

@LuisReinoso The CI fetch the original repo first the check out to the branch that contain your PR:

I tried to checkout to your PR and my lint also result same as on CI

Which is very strange, have you run lint on the right branch? or try updating lint by delete node_modules and run yarn before running lint again

LuisReinoso · 2020-05-09T10:04:10Z

Thanks! I will tried again. Maybe some cache.

LuisReinoso · 2020-05-16T13:35:56Z

I'm back I removed node_modules and installed again via yarn and it works.. Thanks..!

…sage.

LuisReinoso · 2020-05-16T16:49:58Z

Please review my changes. ;)

ZeroX-DG

Can you fix your code and also provide i18n for this please?

ZeroX-DG · 2020-05-19T02:12:12Z

prettier.config

@@ -1,6 +1,5 @@
 {
-  "trailingComma": "es5",
-  "tabWidth": 2,


any reason why you changed this setting?

Do you remember that I had an issue on CI step.?

Now it has the same as master branch:
https://github.com/BoostIO/Boostnote/blob/master/.prettierrc

{ "singleQuote": true, "semi": false, "jsxSingleQuote": true }

ZeroX-DG · 2020-05-19T11:37:34Z

browser/main/modals/PreferencesModal/PluginsTab.js

+  }
+
+  checkPluginsRequirements() {
+    this.checkWakatimePluginRequirement()


This method online call one method, why can't we directly call checkWakatimePluginRequirement?

I was thinking on this page is named plugins so on future new user could use this function to check if their developed plugins has all requirements. But I will remove it.

ZeroX-DG · 2020-05-19T11:42:40Z

browser/lib/wakatime-plugin.js

+  isWrite,
+  hasFileChanges,
+  isFileChange
+) {


The last 3 variable is all booleans. I suggest we change to object type for more clarification. For example, if we change this function to:

function sendWakatimeHeartBeat(storagePath, noteKey, storageName, {isWrite, hasFileChanges, isFileChange}) { ... }

We can keep the code inside the same but when we call this function, we will call it like this:

sendWakatimeHeartBeat( storagePath, noteKey, storageName, { isWrite: true, hasFileChanges: false, isFileChange: true} )

ZeroX-DG · 2020-05-19T11:47:19Z

browser/components/CodeEditor.js

+          false,
+          false,
+          false
+        )


This part seem to be a bit repeative. Surely we can improve the quality of this code by doing something similar to this:

if (this.props.onChange) { this.props.onChange(editor) } const isWrite = !!this.props.onChange; const hasFileChanges = isWrite; if (storage) { sendWakatimeHeartBeat( storage.path, noteKey, storage.name, isWrite, hasFileChanges, false ) }

DONE, It was very old code XD

…me plugin.

LuisReinoso · 2020-05-23T17:56:42Z

Please review my new changes.
Thanks!

ZeroX-DG

Can you change your code and also add support translation for other languages too?

ZeroX-DG · 2020-05-27T02:29:25Z

browser/main/modals/PreferencesModal/PluginsTab.js

+
+  checkWakatimePluginRequirement() {
+    const { wakatime } = this.state.config
+    if (wakatime.isActive && !commandExists('wakatime-cli')) {


This is wrong command name 😄 Should be like this:

Suggested change

if (wakatime.isActive && !commandExists('wakatime-cli')) {

if (wakatime.isActive && !commandExists('wakatime')) {

ZeroX-DG · 2020-05-27T02:32:24Z

browser/main/modals/PreferencesModal/PluginsTab.js

+      <div styleName='root'>
+        <div styleName='group'>
+          <div styleName='group-header'>{i18n.__('Plugins')}</div>
+          <div styleName='group-section'>


I think Wakatime isn't the only plugin that we support so it's better to create a section for Wakatime in this plugin setting page. Just a simple section with title Wakatime and bellow is a check box saying enable wakatime? and below it is the text box for wakatime key. If we plan to only have 1 plugin then this plugin page should change the name to Wakatime which I think will be worst cus harder to change when we want to support more plugins

ZeroX-DG · 2020-06-01T03:30:12Z

@LuisReinoso ping

NOTE: Just a simple section with title Wakatime and bellow is a check box saying enable wakatime? and below it is the text box for wakatime key.

LuisReinoso · 2020-06-07T16:18:06Z

Please review my new changes :D

ZeroX-DG

VERY COOL! I'll approve this. Thanks for this PR 😄

LuisReinoso added 6 commits March 12, 2019 20:02

Add wakatime-plugin BoostIO#2810

6dc8826

Add support to snippetNote BoostIO#2810

052c70b

Add less WakatimeHeartBeat requests BoostIO#2810

57705cf

Add preferences plugins wakatime key BoostIO#2810

39a98e7

Add send wakatimeHeartBeat on constructor CodeEditor to fix when chan…

a0f5a06

…ge from Markdown to Snippet BoostIO#2810

Remove unnecessary console.log

8ec7d19

ZeroX-DG added the awaiting review ❇️ Pull request is awaiting a review. label Mar 13, 2019

ZeroX-DG added awaiting changes 🖊️ Pull request has been reviewed, but contributor needs to make changes. and removed awaiting review ❇️ Pull request is awaiting a review. labels May 4, 2019

LuisReinoso added 3 commits May 8, 2020 06:55

Merge remote-tracking branch 'upstream/master'

2ea0514

fix: Lint issues.

98d4fa0

fix: Update prettier config with master.

2ac38e9

LuisReinoso added 3 commits May 16, 2020 08:37

fix: Lint errors.

938b075

feat: Check for missing wakatime cli. And display modal and alert mes…

fd3e243

…sage.

feat: Add checkbox validation to active or deactive plugin.

6fe6794

ZeroX-DG requested changes May 19, 2020

View reviewed changes

LuisReinoso added 2 commits May 23, 2020 12:21

refactor: Improve sendWakatimeHeartBeat.

1aaba74

fix: Remove extra calling function. Now call directly to check wakati…

c02ab03

…me plugin.

Flexo013 added awaiting review ❇️ Pull request is awaiting a review. and removed awaiting changes 🖊️ Pull request has been reviewed, but contributor needs to make changes. labels May 24, 2020

ZeroX-DG requested changes May 27, 2020

View reviewed changes

ZeroX-DG added awaiting changes 🖊️ Pull request has been reviewed, but contributor needs to make changes. and removed awaiting review ❇️ Pull request is awaiting a review. labels May 27, 2020

LuisReinoso added 2 commits June 7, 2020 11:01

fix: Wakatime command name.

76da76a

refactor: Change UI according requested changes.

8ede1a4

NOTE: Just a simple section with title Wakatime and bellow is a check box saying enable wakatime? and below it is the text box for wakatime key.

ZeroX-DG approved these changes Jun 8, 2020

View reviewed changes

ZeroX-DG added approved 👍 Pull request has been approved by sufficient reviewers. and removed awaiting changes 🖊️ Pull request has been reviewed, but contributor needs to make changes. labels Jun 8, 2020

Rokt33r merged commit 9556417 into BoostIO:master Jul 20, 2020

Rokt33r added this to the v0.16.0 milestone Jul 20, 2020

Flexo013 mentioned this pull request Jul 20, 2020

Wakatime integration #2810

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Wakatime integration #2923

Add Wakatime integration #2923

LuisReinoso commented Mar 13, 2019

ZeroX-DG commented May 4, 2019

LuisReinoso commented May 6, 2019

ZeroX-DG commented Jan 29, 2020

LuisReinoso commented Jan 30, 2020

ZeroX-DG commented Jan 30, 2020

ZeroX-DG commented Apr 23, 2020

ZeroX-DG commented May 7, 2020

LuisReinoso commented May 8, 2020 •

edited

Loading

ZeroX-DG commented May 9, 2020

LuisReinoso commented May 9, 2020

LuisReinoso commented May 16, 2020 •

edited

Loading

LuisReinoso commented May 16, 2020

ZeroX-DG left a comment

ZeroX-DG May 19, 2020

LuisReinoso May 23, 2020 •

edited

Loading

ZeroX-DG May 24, 2020

ZeroX-DG May 19, 2020

LuisReinoso May 23, 2020

ZeroX-DG May 19, 2020

ZeroX-DG May 19, 2020

LuisReinoso May 23, 2020

LuisReinoso commented May 23, 2020

ZeroX-DG left a comment

ZeroX-DG May 27, 2020

LuisReinoso Jun 7, 2020

ZeroX-DG May 27, 2020

LuisReinoso Jun 7, 2020

ZeroX-DG commented Jun 1, 2020

LuisReinoso commented Jun 7, 2020

ZeroX-DG left a comment

	if (wakatime.isActive && !commandExists('wakatime-cli')) {
	if (wakatime.isActive && !commandExists('wakatime')) {

Add Wakatime integration #2923

Add Wakatime integration #2923

Conversation

LuisReinoso commented Mar 13, 2019

Description

Issue fixed

Type of changes

Checklist:

ZeroX-DG commented May 4, 2019

LuisReinoso commented May 6, 2019

ZeroX-DG commented Jan 29, 2020

LuisReinoso commented Jan 30, 2020

ZeroX-DG commented Jan 30, 2020

ZeroX-DG commented Apr 23, 2020

ZeroX-DG commented May 7, 2020

LuisReinoso commented May 8, 2020 • edited Loading

ZeroX-DG commented May 9, 2020

LuisReinoso commented May 9, 2020

LuisReinoso commented May 16, 2020 • edited Loading

LuisReinoso commented May 16, 2020

ZeroX-DG left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

LuisReinoso May 23, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

LuisReinoso commented May 23, 2020

ZeroX-DG left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ZeroX-DG commented Jun 1, 2020

LuisReinoso commented Jun 7, 2020

ZeroX-DG left a comment

Choose a reason for hiding this comment

LuisReinoso commented May 8, 2020 •

edited

Loading

LuisReinoso commented May 16, 2020 •

edited

Loading

LuisReinoso May 23, 2020 •

edited

Loading