Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tweak MarkdownPreview style to optimize overflow scrollbar display #3136

Merged
merged 3 commits into from
Sep 2, 2019
Merged

tweak MarkdownPreview style to optimize overflow scrollbar display #3136

merged 3 commits into from
Sep 2, 2019

Conversation

hikerpig
Copy link
Contributor

@hikerpig hikerpig commented Jul 21, 2019 •
edited by issuehunt-oss bot
Loading

Description

We have only specified the scrollbar style of body element, missed html element, in some cases the default html scrollbar style does not comply with dark theme colors. This PR force the scroll bar to go with body element.

By the way

And also, I fixed a little buggy expression: when scrollPastEnd is falsy, there will be a false appeared in style text, reason:

scrollPastEnd && 'padding-bottom: 90vh;'  // -> may be evaluated to 'false'

Issue fixed

Type of changes

  • 🔘 Improvement (Change that improves the code. Maybe performance or development improvement)

Checklist:

IssueHunt Summary

IssueHunt has been backed by the following sponsors. Become a sponsor

@Flexo013 Flexo013 requested a review from ZeroX-DG July 21, 2019 14:13
@Flexo013 Flexo013 added the needs extra review 🔎 Pull request requires review from an additional reviewer. label Jul 21, 2019
@ZeroX-DG ZeroX-DG added awaiting review ❇️ Pull request is awaiting a review. and removed needs extra review 🔎 Pull request requires review from an additional reviewer. labels Jul 26, 2019
ZeroX-DG
ZeroX-DG approved these changes Aug 25, 2019
View reviewed changes
Copy link
Member

@ZeroX-DG ZeroX-DG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hikerpig Can you fix the conflict before I officially approve it please? Thank you for your great contribution! 🎉

@ZeroX-DG ZeroX-DG added awaiting changes 🖊️ Pull request has been reviewed, but contributor needs to make changes. and removed awaiting review ❇️ Pull request is awaiting a review. labels Aug 25, 2019
@ZeroX-DG ZeroX-DG added approved 👍 Pull request has been approved by sufficient reviewers. and removed awaiting changes 🖊️ Pull request has been reviewed, but contributor needs to make changes. labels Aug 27, 2019
@Rokt33r Rokt33r removed the approved 👍 Pull request has been approved by sufficient reviewers. label Sep 2, 2019
@Rokt33r Rokt33r added this to the v0.13.0 milestone Sep 2, 2019
@Rokt33r Rokt33r merged commit 1332b33 into BoostIO:master Sep 2, 2019
@Flexo013
Copy link
Contributor

This seems to not have entirely worked: #3289 and #3273

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZeroX-DG ZeroX-DG ZeroX-DG approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.13.0
Development

Successfully merging this pull request may close these issues.
4 participants
@hikerpig @Flexo013 @ZeroX-DG @Rokt33r