Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only show context menu if "switch preview" is not set to "on right click" #3186

Merged
merged 1 commit into from
Aug 24, 2019
Merged

Only show context menu if "switch preview" is not set to "on right click" #3186

merged 1 commit into from
Aug 24, 2019

Conversation

RonWalker22
Copy link
Contributor

Description

The new Context Menu for markdown preview mode will only work if "switch preview" is not set to "on right click".

Issue fixed

#3144

Type of changes

  • ⚫ Bug fix (Change that fixed an issue)
  • ⚪ Breaking change (Change that can cause existing functionality to change)
  • ⚪ Improvement (Change that improves the code. Maybe performance or development improvement)
  • ⚪ Feature (Change that adds new functionality)
  • ⚪ Documentation change (Change that modifies documentation. Maybe typo fixes)

Checklist:

  • ⚫ My code follows the project code style
  • ⚪ I have written test for my code and it has been tested
  • ⚪ All existing tests have been passed
  • ⚪ I have attached a screenshot/video to visualize my change if possible

@RonWalker22 RonWalker22 mentioned this pull request Jul 31, 2019
Closed
@ZeroX-DG ZeroX-DG added the awaiting review ❇️ Pull request is awaiting a review. label Aug 2, 2019
ZeroX-DG
ZeroX-DG approved these changes Aug 2, 2019
View reviewed changes
Copy link
Member

@ZeroX-DG ZeroX-DG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@ZeroX-DG ZeroX-DG added approved 👍 Pull request has been approved by sufficient reviewers. and removed awaiting review ❇️ Pull request is awaiting a review. labels Aug 2, 2019
@ZeroX-DG ZeroX-DG changed the title fix #3144 Only show context menu if "switch preview" is not set to "on right click" Aug 5, 2019
@Rokt33r Rokt33r removed the approved 👍 Pull request has been approved by sufficient reviewers. label Aug 24, 2019
@Rokt33r Rokt33r added this to the v0.13.0 milestone Aug 24, 2019
@Rokt33r Rokt33r merged commit 08070f3 into BoostIO:master Aug 24, 2019
@RonWalker22 RonWalker22 deleted the bugfix-#3144 branch September 25, 2019 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZeroX-DG ZeroX-DG ZeroX-DG approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.13.0
Development

Successfully merging this pull request may close these issues.
3 participants
@RonWalker22 @ZeroX-DG @Rokt33r