Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue when creating and saving a new playlist from a selection in the Playlist Editor #193

Closed
touwys opened this issue Jul 25, 2023 · 3 comments · Fixed by #229
Closed

Comments

@touwys
Copy link

touwys commented Jul 25, 2023

Steps:

Playlist Editor > Right-click > Playlist Context Menu > Select "Create New Playlist With Selected Items":

Produces the desired playlist in a new tab named "Untitled-0.m3u8", "Untitled-1.m3u8", etc.

but:

  1. The file format of the playlist in the editor — the one from which the new playlist file is produced, — is M3U. One would expect the same extension to apply to the newly created playlist by default?

  2. To save the new playlist by clicking on the Save button, i.e. the diskette icon on the toolbar, produces an unidentifiable flash of "something" on the screen. It does not produce the expected Save Dialogue box, which usually contains the various saving options such as, for example, the preferred name, the location, nor the desired file extension.

@touwys touwys changed the title Problem creating and saving a new playlist from a selection in the Playlist Editor Issue when creating and saving a new playlist from a selection in the Playlist Editor Jul 26, 2023
@Borewit
Copy link
Owner

Borewit commented Oct 23, 2023

Current behavior is indeed that by the default a .m3u8 playlist is created.

@Borewit
Copy link
Owner

Borewit commented Oct 25, 2023

Regarding the second part:

The save button just saves the new playlist, the flash is the save progress, which seems like flash, as it does not take very long.

It does not produce the expected Save Dialogue box, which usually contains the various saving options such as, for example, the preferred name, the location, nor the desired file extension.

Because it a temporary file, it should show the Save as dialog. Did I break that functionality? I can imagine I did. What if we save directly when creating new playlist, to keep things simpler? To avoid we to keep track which playlist have been saved in a temporary way, clean op temporary files, etc?

@touwys
Copy link
Author

touwys commented Oct 26, 2023

The save button just saves the new playlist, the flash is the save progress, which seems like flash, as it does not take very long.

I guessed that much, but where does this temporary file get saved to? Location? HDD or memory?

Because it a temporary file, it should show the Save as dialog. Did I break that functionality? I can imagine I did. What if we save directly when creating new playlist, to keep things simpler? To avoid we to keep track which playlist have been saved in a temporary way, clean op temporary files, etc?

I do not have a clear picture of exactly you have in mind here. My only concern is that saving a newly created, untitled playlist at the moment, operates without any visible clues — i.e. those user-input dialogues that will usually seek user approval before the file gets saved. Therefore, if you are for supporting a "Save as" dialogue, I'm certainly all for it too.

In summary, I would like to see support for a "Save as" dialogue that appears when the save diskette icon is clicked, allowing the user to exercise those options which are available to them — of which the save location, file name and the file extension appears to be the most prominent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants