Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clipped border #34

Closed
Emailrus opened this issue Sep 12, 2016 · 5 comments
Closed

Clipped border #34

Emailrus opened this issue Sep 12, 2016 · 5 comments
Labels

Comments

@Emailrus
Copy link

It seems, that BEMPathManager doesn't take into account lineWidth, therefore drawings of the box will be clipped at the bottom by container view and drawings of the checkmark will be slightly skewed downwards

@Boris-Em Boris-Em added the bug label Sep 12, 2016
@Boris-Em
Copy link
Owner

That definitely seems like a bug. Would you mind giving repro steps and maybe a screenshot illustrating the issue?
Thanks!

@Emailrus
Copy link
Author

If you take your example project, in storyboard you can already see clipped borders. If you tick checkbox "clip subviews" on checkbox view, you will see clipping in running project too.
It seems my first assumption wasn't entirely correct though: clipping occurs on all sides.

@Boris-Em
Copy link
Owner

My guess is that this has to do with the calculation of the path where the line width is not taking into account. Unfortunately I can't think of a fix, without making the checkbox smaller, which will impact current users of the library.

@Emailrus
Copy link
Author

Yeah, guess in that case it might be better to postpone it to something like a 2.0 release

@Boris-Em
Copy link
Owner

Closing this as a duplicate of issue #47 which is better documented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants