Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression since pre53 ? #317

Closed
Jean-Pierre opened this issue Sep 8, 2015 · 4 comments
Closed

Regression since pre53 ? #317

Jean-Pierre opened this issue Sep 8, 2015 · 4 comments

Comments

@Jean-Pierre
Copy link

Hi,
This example works with pre53 : https://jsfiddle.net/0o8gsbjm/7/

But not with next releases, (last tested: 69) : https://jsfiddle.net/0o8gsbjm/8/
{} removed around FAILED items.

{{for example.john.doe)}}
    <p>index="{{:#getIndex()}}" / name="{{>name}}" / JSON="{{:~json(12)}}" FAILED={:#index} FAILED={:~json(#data)}</p>
{{/for}}

var data = {
    example: {
        john: {
            doe: [ {name:"A"}, {name:"B"}, {name:"C"} ] 
        }
    }
};
@BorisMoore
Copy link
Owner

Hi Jean-Pierre,

It looks like you have an inappropriate ) - should be {{for example.john.doe}}, not {{for example.john.doe)}}.

On removing the paren it seems to work correctly: https://jsfiddle.net/0o8gsbjm/9/

The fact that it worked in 53 was pure luck :) - because somehow the parsing didn't get thrown by the additional ). But that syntax is incorrect of course and not supported.

@Jean-Pierre
Copy link
Author

Yes!
syntax error would be fine :-(

Thanks!
Closed

@BorisMoore
Copy link
Owner

OK - it was not too hard. I have added a test for balanced parens, so in the next update there will be a syntax error for your case above... :)

BorisMoore added a commit to BorisMoore/jsviews.com that referenced this issue Sep 23, 2015
- Many jsviews.com documentation improvements - with JsRender and
  JsRender Node.js Quickstarts
  and JsRender Node.js API topics added.

- Improved syntax error detection

- BorisMoore/jsviews#317
BorisMoore added a commit to BorisMoore/jsviews.com that referenced this issue Sep 23, 2015
- Many jsviews.com documentation improvements - with JsRender and
  JsRender Node.js Quickstarts
  and JsRender Node.js API topics added.

- Improved syntax error detection

- BorisMoore/jsviews#317
BorisMoore added a commit to BorisMoore/jsrender that referenced this issue Sep 23, 2015
- Updated readme

- Improved syntax error detection:
- BorisMoore/jsviews#317
BorisMoore added a commit to BorisMoore/jsrender that referenced this issue Sep 23, 2015
- Updated readme

- Improved syntax error detection:
- BorisMoore/jsviews#317
BorisMoore added a commit to BorisMoore/jsrender that referenced this issue Sep 23, 2015
- Updated readme

- Improved syntax error detection:
- BorisMoore/jsviews#317
BorisMoore added a commit to BorisMoore/jsrender that referenced this issue Sep 23, 2015
- Updated readme

- Improved syntax error detection:
- BorisMoore/jsviews#317
BorisMoore added a commit to BorisMoore/jsrender that referenced this issue Sep 23, 2015
- Updated readme

- Improved syntax error detection:
- BorisMoore/jsviews#317
BorisMoore added a commit to BorisMoore/jsviews.com that referenced this issue Sep 23, 2015
- Many jsviews.com documentation improvements - with JsRender and
  JsRender Node.js Quickstarts
  and JsRender Node.js API topics added.

- Improved syntax error detection

- BorisMoore/jsviews#317
BorisMoore added a commit to BorisMoore/jsviews.com that referenced this issue Sep 24, 2015
- Many jsviews.com documentation improvements - with JsRender and
  JsRender Node.js Quickstarts
  and JsRender Node.js API topics added.

- Improved syntax error detection

- BorisMoore/jsviews#317
BorisMoore added a commit to BorisMoore/jsrender that referenced this issue Sep 24, 2015
- Updated readme

- Improved syntax error detection:
- BorisMoore/jsviews#317
BorisMoore added a commit to BorisMoore/jsviews.com that referenced this issue Sep 24, 2015
- Many jsviews.com documentation improvements - with JsRender and
  JsRender Node.js Quickstarts
  and JsRender Node.js API topics added.

- Improved syntax error detection

- BorisMoore/jsviews#317
BorisMoore added a commit that referenced this issue Sep 24, 2015
- minor update:
  Improved syntax error detection
  #317
@BorisMoore
Copy link
Owner

Improved syntax error detection added in commit 70

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants