refactor: remove paranthesis expression #388

anonrig · 2023-05-25T13:59:05Z

Work in progress.

Fixes #384

github-actions · 2023-05-25T14:46:20Z

Benchmark Results

Linux

group                            main                                   pr
-----                            ----                                   --
minifier/antd.js                 1.01    209.2±2.38ms    30.5 MB/sec    1.00    206.9±2.12ms    30.8 MB/sec
minifier/react.development.js    1.01      2.2±0.02ms    30.7 MB/sec    1.00      2.2±0.02ms    31.0 MB/sec
minifier/typescript.js           1.01    334.4±2.68ms    30.9 MB/sec    1.00    330.6±2.59ms    31.2 MB/sec
minifier/vue.js                  1.01     13.5±0.19ms    24.1 MB/sec    1.00     13.4±0.19ms    24.3 MB/sec
parser/antd.js                   1.00     78.5±0.78ms    81.2 MB/sec    1.01     79.0±1.55ms    80.7 MB/sec
parser/react.development.js      1.00    842.4±5.40µs    81.7 MB/sec    1.00    840.0±7.22µs    81.9 MB/sec
parser/typescript.js             1.00    130.1±0.98ms    79.3 MB/sec    1.00    129.5±0.84ms    79.7 MB/sec
parser/vue.js                    1.00      5.5±0.02ms    59.8 MB/sec    1.00      5.4±0.03ms    59.9 MB/sec

Windows

group                            main                                   pr
-----                            ----                                   --
minifier/antd.js                 1.03    243.3±7.10ms    26.2 MB/sec    1.00    237.4±4.91ms    26.9 MB/sec
minifier/react.development.js    1.51      3.8±1.14ms    17.9 MB/sec    1.00      2.5±0.01ms    27.0 MB/sec
minifier/typescript.js           1.01   367.4±11.09ms    28.1 MB/sec    1.00    365.1±9.75ms    28.3 MB/sec
minifier/vue.js                  1.12     16.9±3.00ms    19.3 MB/sec    1.00     15.1±0.31ms    21.6 MB/sec
parser/antd.js                   1.01     78.5±2.31ms    81.2 MB/sec    1.00     78.0±1.98ms    81.8 MB/sec
parser/react.development.js      1.02   810.7±14.00µs    84.9 MB/sec    1.00    797.0±4.87µs    86.3 MB/sec
parser/typescript.js             1.09   140.5±33.16ms    73.4 MB/sec    1.00    129.4±2.21ms    79.7 MB/sec
parser/vue.js                    1.00      5.4±0.03ms    60.4 MB/sec    1.00      5.4±0.04ms    60.6 MB/sec

Boshen · 2023-05-29T15:11:13Z

I'm working on this in another branch, this is hard than I thought. JavaScript grammar are wild 😭

Boshen · 2023-06-01T12:15:43Z

Oh man this took longer than I thought, and I had to juggle a lot of decisions ...

This is currently in a mergeable state, where the bulk of the work is done. Once merged, we'll be able to fix all the smaller issues one by one, instead of trying to fix everything altogether.

I turned off some of the previous optimizations, because they are interfering with each other. I also turned off some of the tests, because the optimizations aren't done yet.

In the next steps, I'll look into the bigger architecture first, mainly separate out the these interfering optimizations into separate ast passes.

During the meantime, you guys can pick up any commented out test and try to learn some JavaScript Grammar 😄

Boshen · 2023-06-01T12:18:23Z

tasks/minsize/minsize.snap

Things are getting smaller overall! Hooray!

codecov · 2023-06-01T12:20:47Z

Codecov Report

Merging #388 (f348068) into main (4109c8b) will decrease coverage by 0.13%.
The diff coverage is 94.39%.

@@            Coverage Diff             @@
##             main     #388      +/-   ##
==========================================
- Coverage   89.54%   89.42%   -0.13%     
==========================================
  Files         151      151              
  Lines       28093    28159      +66     
==========================================
+ Hits        25156    25181      +25     
- Misses       2937     2978      +41

Impacted Files	Coverage Δ
crates/oxc_hir/src/hir_builder.rs	`87.05% <ø> (-0.12%)`	⬇️
crates/oxc_hir/src/visit_mut.rs	`84.84% <ø> (-0.09%)`	⬇️
crates/oxc_syntax/src/precedence.rs	`53.84% <25.00%> (-46.16%)`	⬇️
crates/oxc_minifier/src/compressor/mod.rs	`81.92% <50.00%> (-17.53%)`	⬇️
crates/oxc_hir/src/precedence.rs	`70.58% <66.66%> (+11.21%)`	⬆️
crates/oxc_minifier/src/printer/gen.rs	`88.34% <96.91%> (+0.31%)`	⬆️
crates/oxc_ast_lower/src/lib.rs	`99.32% <100.00%> (-0.01%)`	⬇️
crates/oxc_hir/src/hir.rs	`26.73% <100.00%> (-0.04%)`	⬇️
crates/oxc_minifier/src/printer/mod.rs	`94.70% <100.00%> (+0.78%)`	⬆️
crates/oxc_parser/src/js/expression.rs	`98.50% <100.00%> (ø)`
... and 1 more

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

mysteryven

It's a great work!

anonrig · 2023-06-01T13:52:24Z

crates/oxc_hir/src/precedence.rs

@@ -24,7 +25,7 @@ impl<'a> GetPrecedence for Expression<'a> {
            Self::NewExpression(expr) => expr.precedence(),
            Self::CallExpression(expr) => expr.precedence(),
            Self::MemberExpression(expr) => expr.precedence(),
-            _ => Precedence::Lowest,
+            _ => Precedence::highest(),


What is the reason for this change? @Boshen

https://tc39.es/ecma262/#sec-ecmascript-language-expressions

The rest are primary expressions, which has the highest precedence.

anonrig requested a review from Boshen May 25, 2023 13:59

anonrig force-pushed the paranthesis-expression branch 2 times, most recently from 8a3d800 to ef180cd Compare May 25, 2023 14:31

Boshen force-pushed the paranthesis-expression branch from ef180cd to d25fd4d Compare May 28, 2023 03:32

Boshen marked this pull request as draft May 29, 2023 15:10

Boshen force-pushed the main branch from 2c9cfb0 to 4c41b27 Compare May 31, 2023 11:20

refactor: remove paranthesis expression from printer

0bc3350

Boshen force-pushed the paranthesis-expression branch from d25fd4d to 58da061 Compare June 1, 2023 12:09

Boshen marked this pull request as ready for review June 1, 2023 12:09

feat(minimizer): print parentheses

f348068

Boshen force-pushed the paranthesis-expression branch from 58da061 to f348068 Compare June 1, 2023 12:10

Boshen requested a review from mysteryven June 1, 2023 12:17

Boshen reviewed Jun 1, 2023

View reviewed changes

tasks/minsize/minsize.snap

Copy link

Member

Boshen Jun 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Things are getting smaller overall! Hooray!

mysteryven approved these changes Jun 1, 2023

View reviewed changes

anonrig commented Jun 1, 2023

View reviewed changes

Boshen merged commit f8125af into main Jun 1, 2023

Boshen deleted the paranthesis-expression branch June 1, 2023 14:45

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor: remove paranthesis expression #388

refactor: remove paranthesis expression #388

anonrig commented May 25, 2023

github-actions bot commented May 25, 2023 •

edited

Loading

Boshen commented May 29, 2023

Boshen commented Jun 1, 2023 •

edited

Loading

Boshen Jun 1, 2023

codecov bot commented Jun 1, 2023

mysteryven left a comment

anonrig Jun 1, 2023

Boshen Jun 1, 2023

Boshen Jun 1, 2023

refactor: remove paranthesis expression #388

refactor: remove paranthesis expression #388

Conversation

anonrig commented May 25, 2023

github-actions bot commented May 25, 2023 • edited Loading

Benchmark Results

Linux

Windows

Boshen commented May 29, 2023

Boshen commented Jun 1, 2023 • edited Loading

Boshen Jun 1, 2023

Choose a reason for hiding this comment

codecov bot commented Jun 1, 2023

Codecov Report

mysteryven left a comment

Choose a reason for hiding this comment

anonrig Jun 1, 2023

Choose a reason for hiding this comment

Boshen Jun 1, 2023

Choose a reason for hiding this comment

Boshen Jun 1, 2023

Choose a reason for hiding this comment

github-actions bot commented May 25, 2023 •

edited

Loading

Boshen commented Jun 1, 2023 •

edited

Loading