-
-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BOM is written CPL content instead of BOM on 2024.06.02 #481
Comments
I confirmed, [2024.06.01] works ok |
Oh snap. I'll fix it later today Thanks for pointing this out. Maybe a good time to add unit tests, just have to figure out how to do that properly |
@Bouni it looks like just the Comment and Designator column headers are swapped in the BOM output, I've been swapping the header manually before uploading it and the site processes it correctly |
Same here ;) |
Please test the latest release, the issue should be fixed now |
Hi @Bouni
You should probably revert this ASAP because it already propagated to the kicad repository.
https://github.com/Bouni/kicad-jlcpcb-tools/blob/5d497a5228437b4b703a32e1a89ba2de8f1dc3a0/fabrication.py#L294C1-L294C62
It probably wasn't intended, but if it was, jlc seems not to accept this format of BOM.
Best regards
The text was updated successfully, but these errors were encountered: