Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BOM is written CPL content instead of BOM on 2024.06.02 #481

Closed
cr1tbit opened this issue Jun 13, 2024 · 5 comments · Fixed by #482
Closed

BOM is written CPL content instead of BOM on 2024.06.02 #481

cr1tbit opened this issue Jun 13, 2024 · 5 comments · Fixed by #482

Comments

@cr1tbit
Copy link

cr1tbit commented Jun 13, 2024

Hi @Bouni

You should probably revert this ASAP because it already propagated to the kicad repository.

https://github.com/Bouni/kicad-jlcpcb-tools/blob/5d497a5228437b4b703a32e1a89ba2de8f1dc3a0/fabrication.py#L294C1-L294C62

It probably wasn't intended, but if it was, jlc seems not to accept this format of BOM.

image

Best regards

@cr1tbit
Copy link
Author

cr1tbit commented Jun 13, 2024

I confirmed, [2024.06.01] works ok

@Bouni
Copy link
Owner

Bouni commented Jun 13, 2024

Oh snap. I'll fix it later today

Thanks for pointing this out.

Maybe a good time to add unit tests, just have to figure out how to do that properly

@mikesmitty
Copy link

@Bouni it looks like just the Comment and Designator column headers are swapped in the BOM output, I've been swapping the header manually before uploading it and the site processes it correctly

@Adesin-fr
Copy link

@Bouni it looks like just the Comment and Designator column headers are swapped in the BOM output, I've been swapping the header manually before uploading it and the site processes it correctly

Same here ;)
File is not recognized at JLCPCB !

@Bouni
Copy link
Owner

Bouni commented Jun 19, 2024

Please test the latest release, the issue should be fixed now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants