Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix mapper tests for older pyspark version #62

Merged
merged 2 commits into from
Jun 14, 2024
Merged

Fix mapper tests for older pyspark version #62

merged 2 commits into from
Jun 14, 2024

Conversation

rt-phb
Copy link
Collaborator

@rt-phb rt-phb commented Jun 13, 2024 •
edited
Loading

  • exception message looks different for older pyspark versions, maybe we should add some custom text to the message?
  • .dtypes returns "null" for pyspark 3.1.3 and "void" for newer versions. T._parse_datatype_string can not handle "null" properly

@rt-phb rt-phb added the test-it Triggers github test action label Jun 13, 2024
@rt-phb rt-phb added test-it Triggers github test action and removed test-it Triggers github test action labels Jun 14, 2024
@rt-phb rt-phb changed the title Update match regex for older pytest version Update match regex for older pyspark version Jun 14, 2024
@rt-phb rt-phb changed the title Update match regex for older pyspark version Fix mapper tests for older pyspark version Jun 14, 2024
@rt-phb rt-phb merged commit 19310a7 into master Jun 14, 2024
8 checks passed
@rt-phb rt-phb deleted the update_match_regex_for_mapper_tests branch June 14, 2024 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Selbstsesslingen Selbstsesslingen Selbstsesslingen approved these changes

Assignees
No one assigned
Labels
test-it Triggers github test action
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rt-phb @Selbstsesslingen