Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure Pressure Sensor and Setpoints #551

Open
connorjcantrell opened this issue Aug 30, 2023 · 3 comments
Open

Restructure Pressure Sensor and Setpoints #551

connorjcantrell opened this issue Aug 30, 2023 · 3 comments

Comments

@connorjcantrell
Copy link
Contributor

connorjcantrell commented Aug 30, 2023

I'd like to suggest expanding our Pressure Sensor and Setpoint categories to include more specific subclasses. I've outlined this proposed structure using a file system layout, where symbolic links serve as indicators for classes that have multiple parents.

I have only created the Pressure Sensor class, however, Pressure Setpoint would be similar.

This is a starting point, I'm looking forward to receiving feedback and suggestions.

Pressure_Sensor
├── Air_Pressure_Sensor
│   ├── Air_Differential_Pressure_Sensor
│   │   ├── Discharge_Air_Differential_Pressure_Sensor
│   │   ├── Exhaust_Air_Differential_Pressure_Sensor
│   │   ├── Filter_Air_Differential_Pressure_Sensor
│   │   ├── Return_Air_Differential_Pressure_Sensor
│   │   └── Supply_Air_Differential_Pressure_Sensor
│   ├── Air_Static_Pressure_Sensor
│   │   ├── Building_Air_Static_Pressure_Sensor
│   │   ├── Discharge_Air_Static_Pressure_Sensor
│   │   ├── Supply_Air_Static_Pressure_Sensor
│   │   └── Underfloor_Plenum_Air_Static_Pressure_Sensor
│   ├── Air_Total_Pressure_Sensor
│   │   ├── Return_Air_Total_Pressure_Sensor
│   │   └── Supply_Air_Total_Pressure_Sensor
│   └── Air_Velocity_Pressure_Sensor
│       ├── Discharge_Air_Velocity_Pressure_Sensor
│       ├── Exhaust_Air_Velocity_Pressure_Sensor
│       └── Supply_Air_Velocity_Pressure_Sensor
├── Differential_Pressure_Sensor
│   ├── Air_Differential_Pressure_Sensor -> ../Air_Pressure_Sensor/Air_Differential_Pressure_Sensor
│   └── Water_Differential_Pressure_Sensor -> ../Water_Pressure_Sensor/Water_Differential_Pressure_Sensor
├── Static_Pressure_Sensor
│   └── Air_Static_Pressure_Sensor -> ../Air_Pressure_Sensor/Air_Static_Pressure_Sensor
├── Total_Pressure_Sensor
│   └── Air_Total_Pressure_Sensor -> Air_Pressure_Sensor/Air_Total_Pressure_Sensor
├── Velocity_Pressure_Sensor
│   └── Air_Velocity_Pressure_Sensor -> ../Air_Pressure_Sensor/Air_Velocity_Pressure_Sensor
└── Water_Pressure_Sensor
    ├── Entering_Water_Pressure_Sensor
    │   ├── Entering_Water_Absolute_Pressure_Sensor -> Water_Absolute_Pressure_Sensor/Entering_Water_Absolute_Pressure_Sensor
    │   └── Entering_Water_Gauge_Pressure_Sensor -> Water_Gauge_Pressure_Sensor/Entering_Water_Gauge_Pressure_Sensor
    ├── Leaving_Water_Pressure_Sensor
    │   ├── Leaving_Water_Absolute_Pressure_Sensor -> Water_Absolute_Pressure_Sensor/Leaving_Water_Absolute_Pressure_Sensor
    │   └── Leaving_Water_Gauge_Pressure_Sensor -> Water_Gauge_Pressure_Sensor/Leaving_Water_Gauge_Pressure_Sensor
    ├── Water_Absolute_Pressure_Sensor
    │   ├── Entering_Water_Absolute_Pressure_Sensor
    │   └── Leaving_Water_Absolute_Pressure_Sensor
    ├── Water_Differential_Pressure_Sensor
    │   ├── Chilled_Water_Differential_Pressure_Sensor
    │   ├── Filter_Water_Differential_Pressure_Sensor
    │   └── Hot_Water_Differential_Pressure_Sensor
    │       ├── Domestic_Hot_Water_Differential_Pressure_Sensor
    │       └── Heating_Hot_Water_Differential_Pressure_Sensor
    └── Water_Gauge_Pressure_Sensor
        ├── Entering_Water_Absolute_Pressure_Sensor
        └── Leaving_Water_Absolute_Pressure_Sensor
@connorjcantrell
Copy link
Contributor Author

@gtfierro Is it possible to consider adding this in 1.4 too?

@gtfierro
Copy link
Member

Yes, that would be great! I like this organization. Can you explain what the lines like this mean?

├── Differential_Pressure_Sensor
│   ├── Air_Differential_Pressure_Sensor -> ../Air_Pressure_Sensor/Air_Differential_Pressure_Sensor

Does this mean that air_differential_pressure_sensor is moving? Or that it just exists in two places?

@gtfierro gtfierro added this to the 1.4.0 Pre-Release milestone Dec 13, 2023
@connorjcantrell
Copy link
Contributor Author

Sorry, the above example was made using a folder structure. -> ../some/path is a symlink, which translates to the class having two parents

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants