Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not compatible with ES5 #2

Closed
c4ndybar opened this issue Sep 4, 2018 · 3 comments
Closed

Not compatible with ES5 #2

c4ndybar opened this issue Sep 4, 2018 · 3 comments

Comments

@c4ndybar
Copy link
Contributor

c4ndybar commented Sep 4, 2018

Could we transpile this down to es5 so it is compatible with older browsers? The code appears to be ES6/7 compliant currently.

@BridgeAR
Copy link
Owner

BridgeAR commented Sep 4, 2018

The features used in this module should be supported by pretty much all browsers with a usage > 0.5%. Are you really facing difficulties with users that use very outdated browsers?

@c4ndybar
Copy link
Contributor Author

c4ndybar commented Sep 4, 2018

Unfortunately, I have to target IE11 (which according to this site still has ~3% market share). You can see here that IE11 has almost no support for es6+ features.

I'm using a manually transpiled version right now, but that's obviously not ideal. I'd appreciate if you could transpile the library if it's not too much trouble.

@BridgeAR
Copy link
Owner

BridgeAR commented Sep 5, 2018

@c4ndybar I added support for IE11 by removing the arrow function and let. This should be enough to target IE11. Please let me know if you run into any issues. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants