Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop calculating a verification per user for each app/expression in scorer #342

Open
abramsymons opened this issue Dec 15, 2022 · 0 comments
Assignees

Comments

@abramsymons
Copy link
Collaborator

The scorer has an apps verification calculation beside the bitu, meets, etc that loops over all users and evaluates all existing verification expressions for the user, and inserts a document into the verifications collection for each expression that the user is verified for.
These verification documents are used by the batch verification querying endpoint in v5:
https://node.brightid.org/brightid/v5/verifications/{app}

Calculating these verifications and inserting them in the database is very time-consuming and can be removed if we update the batch verification endpoint in v5 to simply return all the linked users for the app without checking if they are verified or not.

The linking process in v5 can also be updated to prevent users that are not verified to link. In this way returning the list of all links in the batch verification endpoint is almost equivalent to returning the list of verified users of the app.

But v5 apps should still be encouraged to not rely on this endpoint result as a verification method because it will include the links that was verified in past but are not anymore. Apps should rely on the single verification endpoint instead.

@siftal siftal self-assigned this Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants