Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Java 12 and fix link in README to Oracle Java SE #270

Closed
HEdingfield opened this issue May 15, 2019 · 4 comments
Closed

Update to Java 12 and fix link in README to Oracle Java SE #270

HEdingfield opened this issue May 15, 2019 · 4 comments

Comments

@HEdingfield
Copy link
Contributor

We should be linking to and using OpenJDK, per this article.

#239 is likely a blocker for this.

The most straightforward thing to link and use would probably be Oracle's open source builds of the JDK here.

@HEdingfield HEdingfield added this to the v 0.9 Cleanup milestone May 15, 2019
@HEdingfield HEdingfield self-assigned this May 15, 2019
@HEdingfield
Copy link
Contributor Author

Counterpoint: we may want to stick with Java 11, since it's LTS until 2022 per the table here. In either case, we're still updating to a new version of Java.

@tarheel
Copy link
Contributor

tarheel commented May 15, 2019

Any particular downside to going straight to 12?

@HEdingfield
Copy link
Contributor Author

See my previous comment. Means we'd need to stay on top of new versions every 6 months, whereas 11 is LTS until 2022. It's probably still worth going to 12 and beyond, but we need to have a discussion about the certification process, who's responsible for building the code, if we need to stick with images frozen in time, etc.

@HEdingfield
Copy link
Contributor Author

Addressed via #272. Now the tabulator only works in JDK 11+. When distributed using Gradle's distZip task, it requires that the user have the JDK installed. When distributed using Gradle's jlink task, it doesn't even require that the user have the JDK installed (the zip is 48 MB vs. 26 MB with distZip).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants