Cert bug fixes #287
Merged
Cert bug fixes #287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarheel
reviewed
Jun 17, 2019
There was a problem hiding this comment.
It all looks good to me. I'll give @HEdingfield a chance to review also.
# Conflicts: # src/main/java/network/brightspots/rcv/GuiApplication.java # src/main/java/network/brightspots/rcv/Logger.java # src/main/java/network/brightspots/rcv/TabulatorSession.java # src/main/java/network/brightspots/rcv/TieBreak.java
HEdingfield
requested changes
Jun 17, 2019
HEdingfield
requested changes
Jun 18, 2019
There was a problem hiding this comment.
Nice, getting close! Went through everything and made some more suggestions (did them as suggestions so you can accept them right in the GH comments hopefully).
A couple of other important things to address:
- There are around 20-30 files that still look stuck in com/rcv, so this PR is currently attempting to move them back from network/brightspots/rcv... need to fix this.
- Try deleting these:
.idea/_artifacts,idea/artifacts,.idea/kotlinc.xml. I'm 95% sure these are just leftovers from pre-Gradle days and no longer serve any purpose.
Co-Authored-By: HEdingfield <HEdingfield@users.noreply.github.com>
Co-Authored-By: HEdingfield <HEdingfield@users.noreply.github.com>
Co-Authored-By: HEdingfield <HEdingfield@users.noreply.github.com>
Co-Authored-By: HEdingfield <HEdingfield@users.noreply.github.com>
Co-Authored-By: HEdingfield <HEdingfield@users.noreply.github.com>
Co-Authored-By: HEdingfield <HEdingfield@users.noreply.github.com>
Co-Authored-By: HEdingfield <HEdingfield@users.noreply.github.com>
Co-Authored-By: HEdingfield <HEdingfield@users.noreply.github.com>
HEdingfield
approved these changes
Jun 19, 2019
This was referenced Jun 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This contains fixes for #278 #141 and #271
I generally tried to improve the log messaging and surface issues and status in a clearer and more consistent way.