Cert bug fixes

src/main/java/com/rcv/ContestConfig.java

@@ -128,8 +128,13 @@ static ContestConfig loadContestConfig(String configPath) {
       Logger.log(Level.INFO, "Successfully loaded contest config: %s", configPath);
       // perform some additional sanity checks
       if (rawConfig.validate()) {
-        // checks passed so continue processing
-        config = loadContestConfig(rawConfig, new File(configPath).getParent());
+        // source folder will be the parent of configPath
+        String parentFolder = new File(configPath).getParent();
+        // if there is no parent folder use current working directory
+        if (parentFolder == null) {
+          parentFolder = System.getProperty("user.dir");
+        }
+        config = loadContestConfig(rawConfig, parentFolder);
       } else {
         Logger.log(Level.SEVERE, "Failed to create contest config!");
       }

src/main/java/com/rcv/GuiApplication.java

@@ -16,6 +16,10 @@
 
 package com.rcv;
 
+import java.io.IOException;
+import java.io.PrintWriter;
+import java.io.StringWriter;
+import java.util.logging.Level;
 import javafx.application.Application;
 import javafx.application.Platform;
 import javafx.event.EventHandler;
@@ -28,10 +32,18 @@
 public class GuiApplication extends Application {
 
   @Override
-  public void start(Stage window) throws Exception {
-    Parent root = FXMLLoader.load(getClass().getResource("/com/rcv/GuiConfigLayout.fxml"));
-    window.setTitle("RCVRC Tabulator");
-    window.setScene(new Scene(root));
+  public void start(Stage window) {
+    String resourcePath = "/com/rcv/GuiConfigLayout.fxml";
+    try {
+      Parent root = FXMLLoader.load(getClass().getResource(resourcePath));
+      window.setTitle("RCVRC Tabulator");
+      window.setScene(new Scene(root));
+    } catch (IOException exception) {
+      StringWriter sw = new StringWriter();
+      PrintWriter pw = new PrintWriter(sw);
+      exception.printStackTrace(pw);
+      Logger.log(Level.SEVERE, "Failed to open: %s:\n%s. ", resourcePath, sw.toString());
+    }
     // cache main window so we can parent file choosers to it
     GuiContext context = GuiContext.getInstance();
     context.setMainWindow(window);

src/main/java/com/rcv/Logger.java

@@ -71,7 +71,7 @@ class Logger {
   // function: setup
   // purpose: initialize logging module
   // throws: IOException if unable to open output log file
-  static void setup() throws IOException {
+  static void setup() {
     // cache default logger
     logger = java.util.logging.Logger.getLogger("");
     logger.setLevel(Level.FINE);
@@ -82,20 +82,27 @@ static void setup() throws IOException {
     Path logPath =
         Paths.get(System.getProperty("user.dir"), EXECUTION_LOG_FILE_NAME).toAbsolutePath();
 
-    // executionHandler writes to the execution log file
-    FileHandler executionHandler =
-        new FileHandler(
-            logPath.toString(), LOG_FILE_MAX_SIZE_BYTES, EXECUTION_LOG_FILE_COUNT, true);
-    executionHandler.setLevel(Level.INFO);
-    logger.addHandler(executionHandler);
+    // executionHandler writes to the execution log file in current working directory
+    try {
+      FileHandler executionHandler =
+          new FileHandler(
+              logPath.toString(), LOG_FILE_MAX_SIZE_BYTES, EXECUTION_LOG_FILE_COUNT, true);
+      executionHandler.setLevel(Level.INFO);
+      logger.addHandler(executionHandler);
+    } catch (IOException exception) {
+      log(Level.WARNING, (String.format("Failed to start system logging!\n" +
+              "Make sure you have write access in %s\n%s.",
+          System.getProperty("user.dir"),
+          exception.toString())));
+    }
 
     // use our custom formatter for all installed handlers
     for (Handler handler : logger.getHandlers()) {
       handler.setFormatter(formatter);
     }
 
     // log results
-    log(Level.INFO, "RCV Tabulator logging execution to: %s", logPath.toString());
+    log(Level.INFO, "RCV Tabulator logging to: %s", logPath.toString());
   }
 
   // function: addTabulationFileLogging

src/main/java/com/rcv/Main.java

@@ -20,7 +20,6 @@
 
 package com.rcv;
 
-import java.io.IOException;
 import java.util.ArrayList;
 import java.util.List;
 import java.util.logging.Level;
@@ -32,11 +31,7 @@ public class Main extends GuiApplication {
   // param: args command line argument array
   // returns: N/A
   public static void main(String[] args) {
-    try {
-      Logger.setup();
-    } catch (IOException exception) {
-      System.err.print(String.format("Failed to start system logging!\n%s", exception.toString()));
-    }
+    Logger.setup();
 
     // Determine if user intends to use the command-line interface, and gather args if so
     boolean useCli = false;

src/main/java/com/rcv/TieBreak.java

@@ -20,12 +20,15 @@
 package com.rcv;
 
 import java.io.IOException;
+import java.io.PrintWriter;
+import java.io.StringWriter;
 import java.math.BigDecimal;
 import java.util.ArrayList;
 import java.util.HashSet;
 import java.util.LinkedList;
 import java.util.List;
 import java.util.Map;
+import java.util.Scanner;
 import java.util.Set;
 import java.util.SortedMap;
 import java.util.concurrent.Callable;
@@ -190,8 +193,8 @@ private String doInteractiveCli() {
     String selectedCandidate = null;
     while (selectedCandidate == null || selectedCandidate.isEmpty()) {
       // TODO: Create and enable cancel option for interactive tiebreaker CLI
-      // container for user console input
-      String userInput = System.console().readLine();
+      Scanner sc = new Scanner(System.in);
+      String userInput = sc.nextLine();
       try {
         // user selected loser parsed to int
         int choice = Integer.parseInt(userInput);
@@ -303,20 +306,20 @@ public String call() {
       window.initModality(Modality.APPLICATION_MODAL);
       window.setTitle("RCV Tiebreaker");
       String resourcePath = "/com/rcv/GuiTiebreakerLayout.fxml";
-      FXMLLoader loader = new FXMLLoader(getClass().getResource(resourcePath));
-
       try {
+        FXMLLoader loader = new FXMLLoader(getClass().getResource(resourcePath));
         Parent root = loader.load();
         GuiTiebreakerController controller = loader.getController();
         controller.populateTiedCandidates(tiedCandidates);
         window.setScene(new Scene(root));
         window.showAndWait();
         candidateToEliminate = controller.getCandidateToEliminate();
       } catch (IOException exception) {
-        Logger.log(
-            Level.SEVERE, "Failed to open: %s:\n%s", resourcePath, exception.getCause().toString());
+        StringWriter sw = new StringWriter();
+        PrintWriter pw = new PrintWriter(sw);
+        exception.printStackTrace(pw);
+        Logger.log(Level.SEVERE, "Failed to open: %s:\n%s. ", resourcePath,sw.toString());
       }
-
       return candidateToEliminate;
     }
   }

src/test/java/com/rcv/TabulatorTests.java

@@ -180,12 +180,7 @@ private static void compareJson(
   // purpose: runs once at the beginning of testing to setup logging
   @BeforeAll
   static void setup() {
-    try {
       Logger.setup();
-    } catch (IOException exception) {
-      // this is non-fatal
-      System.err.print(String.format("Failed to start system logging!\n%s", exception.toString()));
-    }
   }
 
   // function: invalidParamsTest