Redesigns handling of nonIntegerWinningThreshold and hareQuota in the GUI
#512
Conversation
…currently-selected tab.
…r`, with minor refactoring. Suppresses warnings that aren't useful. Auto-rearranging of some methods.
… with a radio button array in the FXML file.
…ectionMode is "Bottoms-up using percentage threshold"; fixes bugs in validation error messages when numberOfWinners is 0; suppresses rawtypes warnings in `GuiConfigController`.
…reshold and hareQuota values, and adds new validation rules for those settings; GUI now disables numberOfWinners field and sets it to 1 only when WinnerElectionMode is "Single-winner majority determines winner".
| if (!isMultiSeatAllowOnlyOneWinnerPerRoundEnabled() | ||
| && !isMultiSeatAllowMultipleWinnersPerRoundEnabled()) { |
There was a problem hiding this comment.
perhaps it would be useful to have a helper like isStandardMultiSeatEnabled() that matches these two modes?
There was a problem hiding this comment.
If we end up doing the same check in the future, I'd be on board with this, but will leave as-is for now.
| textFieldNumberOfWinners.setDisable(false); | ||
| } | ||
| case MULTI_SEAT_BOTTOMS_UP_USING_PERCENTAGE_THRESHOLD -> { | ||
| textFieldMaxRankingsAllowed.setDisable(false); | ||
| textFieldMinimumVoteThreshold.setDisable(false); | ||
| choiceTiebreakMode.setDisable(false); | ||
| checkBoxHareQuota.setDisable(false); | ||
| textFieldNumberOfWinners.setDisable(false); | ||
| textFieldNumberOfWinners.setText("0"); |
There was a problem hiding this comment.
can we hide it entirely in this case?
There was a problem hiding this comment.
The answer is yes, but it wouldn't move any of the options around, it'd just appear as a blank space there, which is awkward. I also think we've had this conversation a number of times and I've been pretty firmly in the camp of keeping the user as aware of what ends up in the config file as possible. Happy to reassess this in the future for the entire GUI if you'd like to file an issue for that. Chris would probably be excited about this idea.
src/main/resources/network/brightspots/rcv/GuiConfigLayout.fxml
Outdated
Show resolved
Hide resolved
…ANDARD` to `WinnerElectionMode.STANDARD_SINGLE_WINNER`.
checkBoxNonIntegerWinningThresholdandcheckBoxHareQuotawith a radio button array in the FXML file (addressing RedesignnonIntegerWinningThresholdandhareQuotain GUI and add new validation rule #501)nonIntegerWinningThresholdandhareQuotavalues, and adds new validation rules for those settings.numberOfWinnersfield and sets it to 1 only whenwinnerElectionModeis "Single-winner majority determines winner".numberOfWinnersfield and sets it to 0 whenwinnerElectionModeis "Bottoms-up using percentage threshold".numberOfWinnersis 0rawtypeswarnings inGuiConfigController.