Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redesigns handling of nonIntegerWinningThreshold and hareQuota in the GUI #512

Merged
merged 8 commits into from
Sep 27, 2020
Merged

Redesigns handling of nonIntegerWinningThreshold and hareQuota in the GUI #512

merged 8 commits into from
Sep 27, 2020

Commits on Sep 25, 2020

  1. Changes the TextArea on the right to display hints specific to the … 

    …currently-selected tab.
    @HEdingfield
    HEdingfield committed Sep 25, 2020
    Configuration menu
    Copy the full SHA
    d00e3e1 View commit details
    Browse the repository at this point in the history

  2. Creates throwIfNoUwiLabel helper function in `CommonDataFormatReade… 

    …r`, with minor refactoring. Suppresses warnings that aren't useful. Auto-rearranging of some methods.
    @HEdingfield
    HEdingfield committed Sep 25, 2020
    Configuration menu
    Copy the full SHA
    9059ecf View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2020

  1. Replaces checkBoxNonIntegerWinningThreshold and checkBoxHareQuota… 

    … with a radio button array in the FXML file.
    @HEdingfield
    HEdingfield committed Sep 26, 2020
    Configuration menu
    Copy the full SHA
    7f34217 View commit details
    Browse the repository at this point in the history

  2. GUI now disables numberOfWinners field and sets it to 0 when WinnerEl… 

    …ectionMode is "Bottoms-up using percentage threshold"; fixes bugs in validation error messages when numberOfWinners is 0; suppresses rawtypes warnings in `GuiConfigController`.
    @HEdingfield
    HEdingfield committed Sep 26, 2020
    Configuration menu
    Copy the full SHA
    89f5eba View commit details
    Browse the repository at this point in the history

  3. Implements radio button array in GUI to determine nonIntegerWinningTh… 

    …reshold and hareQuota values, and adds new validation rules for those settings; GUI now disables numberOfWinners field and sets it to 1 only when WinnerElectionMode is "Single-winner majority determines winner".
    @HEdingfield
    HEdingfield committed Sep 26, 2020
    Configuration menu
    Copy the full SHA
    0623206 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'develop' into threshold-calc-radio

    @HEdingfield
    HEdingfield committed Sep 26, 2020
    Configuration menu
    Copy the full SHA
    a97ce71 View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2020

  1. Add comment per review feedback.

    @HEdingfield
    HEdingfield committed Sep 27, 2020
    Configuration menu
    Copy the full SHA
    7efb713 View commit details
    Browse the repository at this point in the history

  2. Addressing review feedback, including renaming `WinnerElectionMode.ST… 

    …ANDARD` to `WinnerElectionMode.STANDARD_SINGLE_WINNER`.
    @HEdingfield
    HEdingfield committed Sep 27, 2020
    Configuration menu
    Copy the full SHA
    96e4483 View commit details
    Browse the repository at this point in the history