Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default OAuth Scopes have changed and tests fail #17

Closed
mirestrepo opened this issue Jan 11, 2023 · 1 comment · Fixed by #19
Closed

Default OAuth Scopes have changed and tests fail #17

mirestrepo opened this issue Jan 11, 2023 · 1 comment · Fixed by #19
Assignees
Labels

Comments

@mirestrepo
Copy link
Member

Scopes that GKE adds are listed here

For some reason our change seems to indicate that we didn't use house a custom service account and now we do?

@mirestrepo mirestrepo added the fix label Jan 11, 2023
@digicosmos86 digicosmos86 self-assigned this Jul 8, 2023
@digicosmos86
Copy link
Contributor

So I guess because of the changes on our end (we are now using a custom service account?), we should change the expected values of the tests right?

@digicosmos86 digicosmos86 linked a pull request Jul 8, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants