Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encrypt Service Name !!! #365

Closed
5andr0 opened this issue Jul 9, 2024 · 3 comments
Closed

Encrypt Service Name !!! #365

5andr0 opened this issue Jul 9, 2024 · 3 comments
Milestone

Comments

@5andr0
Copy link

5andr0 commented Jul 9, 2024

Why was service name not considered sensible when you added encryption?
I'm not allowed to leak any of my sensible 2FA services, so I had to double check the code if my data is really 100% encrypted, but service name was NOT ENCRYPTED!
It would be nice if I didn't have to add extra encryption to the database file manually before syncing it to the backup cloud.

I will leave a donation when this gets implemented!

@Bubka
Copy link
Owner

Bubka commented Jul 9, 2024

The decision was made to allow server-side filtering/searching on services. I understand it can be considered as sensitive as the secret or the email data though.

The unexpected part is that finally no server side filtering is implemented 😅.

I don't want to restrict the api capabilities completely, so I suggest to handle it via an admin option. Something like a yes/no checkbox called "Encrypt service names" and a legend explaining why and how it affects the behavior of the api. It could be set to On by default.

@5andr0
Copy link
Author

5andr0 commented Jul 10, 2024

I feel you man, it's hard to maintain an open source project for free. There's so many nice ideas, but not enough time 😅
I'll support you a bit with a donation, since this is the only option for a self hosted totp service with a nice UI. So thanks for making it public!

Just query all the users entries and decrypt them on the fly for filtering in php. There shouldn't be much of a performance impact compared to sql query filtering. Might be even faster if you cache the decrypted data

@Bubka
Copy link
Owner

Bubka commented Jul 10, 2024

Many thanks for your feedback and your sponsor. I hope to have some time in August to work on this, it will be at the top of the list.

@Bubka Bubka added this to the v5.3.0 milestone Sep 2, 2024
@Bubka Bubka closed this as completed in e0d2786 Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Released
Development

No branches or pull requests

2 participants