Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

notifications regression: NotificationClosed emitted with wrong type #118

Closed
The-Compiler opened this issue May 2, 2022 · 1 comment · Fixed by #119
Closed

notifications regression: NotificationClosed emitted with wrong type #118

The-Compiler opened this issue May 2, 2022 · 1 comment · Fixed by #119
Assignees
Labels
bug Something isn't working

Comments

@The-Compiler
Copy link

Description

When a notification is closed, NotificationClosed is emitted with uint32, int32 as arguments (id, reason) while the specification mandates uint32 for both.

Budgie version

budgie-desktop 10.6.1

This seems to be a recent regression: On a fresh Solus 4.3 install I can't reproduce, only after a full update.

Operating system

Solus 4.3

Steps to reproduce the issue

  • Run dbus-monitor interface=org.freedesktop.Notifications
  • Trigger a notification, e.g. by running notify-send foo in another terminal

Actual result

signal time=1651502524.321176 sender=:1.42 -> destination=(null destination) serial=73 path=/org/freedesktop/Notifications; interface=org.freedesktop.Notifications; member=NotificationClosed
   uint32 2
   int32 2

Expected result

uint32 2 for both arguments

Additional information

This currently causes qutebrowser to crash when a notification is closed - will add a workaround there too.

The-Compiler added a commit to qutebrowser/qutebrowser that referenced this issue May 2, 2022
@EbonJaeger EbonJaeger self-assigned this May 2, 2022
@EbonJaeger EbonJaeger added the bug Something isn't working label May 2, 2022
The-Compiler added a commit to qutebrowser/qutebrowser that referenced this issue May 2, 2022
EbonJaeger added a commit that referenced this issue May 2, 2022
Ref #118

Signed-off-by: Evan Maddock <maddock.evan@vivaldi.net>
@EbonJaeger
Copy link
Member

I neglected to realize that enum values are int32 not uint32. Just made a PR to fix that. Sorry for the inconvenience!

JoshStrobl pushed a commit that referenced this issue May 3, 2022
Ref #118

Signed-off-by: Evan Maddock <maddock.evan@vivaldi.net>
twigleingrid pushed a commit to twigleingrid/qutebrowser that referenced this issue May 13, 2022
serebit pushed a commit that referenced this issue Jun 11, 2022
Ref #118

Signed-off-by: Evan Maddock <maddock.evan@vivaldi.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants