Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Take keywords and generic name into account for relevancy #439

Merged
merged 2 commits into from
Sep 5, 2023

Conversation

Gaarco
Copy link
Contributor

@Gaarco Gaarco commented Sep 1, 2023

Description

Attempt to address #347 #421

Performs fuzzy search on name, generic name and keywords and uses the best result as score.
Also adjusted the threshold to include more relevant applications since some were previously excluded even though the app name included the search keyword.

Submitter Checklist

  • Squashed commits with git rebase -i (if needed)
  • Built budgie-desktop and verified that the patch worked (if needed)

@EbonJaeger EbonJaeger added the enhancement New feature or request label Sep 1, 2023
@EbonJaeger EbonJaeger self-requested a review September 1, 2023 14:54
Copy link
Member

@EbonJaeger EbonJaeger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks pretty good. Thanks! Do you have any examples of testing, like "application A used to be lower/not shown when expected, and now it is"? Just so we have something to go off of.

src/appindexer/RelevancyService.vala Show resolved Hide resolved
@Gaarco
Copy link
Contributor Author

Gaarco commented Sep 1, 2023

Searching for "GIMP" didn't show anything before, now it displays the application.
When searching for "settings," it used to show only Budgie Desktop Settings, it now also displays the Budgie Control Center, PulseAudio Volume Control and others.

Copy link
Member

@EbonJaeger EbonJaeger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, and it works really well for searching for generic terms like "browser", "editor", or "terminal"! Kicking over to Josh for final review. :)

Copy link
Member

@JoshStrobl JoshStrobl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@JoshStrobl JoshStrobl merged commit 721914f into BuddiesOfBudgie:main Sep 5, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
4 participants