notifications: Try to guess app id if getting from hints fails #479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change will result in Discord iconography being that of the avatar of the first avatar of the first person / channel / server you get a notification from, regardless of whether or not any other notifications come from the same source, That's why I have it set to prioritize the app info image. |
|
See 6c0608b The specification is for the Notification itself, it shouldn't dictate how it should be handled in Raven. I would be curious what sort of AppInfo we are getting from those applications sending the notifications. |
|
Gonna give this more thought... |
EbonJaeger
force-pushed
the
477-notification-icons-broken-bug
branch
from
a438856
to
627710d
Compare
EbonJaeger
changed the title
The notification spec states that the `desktop-entry` hint should be the prefix of the Desktop Application Info file. However, because of the push to have fully-qualified app ID's, some applications now have a mismatch between the ID and the desktop file, meaning the hint cannot be used for that application. In cases where the hint fails, try to guess the ID using the application's name given to us from DBus. It seems to fix #477. Signed-off-by: Evan Maddock <maddock.evan@vivaldi.net>
EbonJaeger
force-pushed
the
477-notification-icons-broken-bug
branch
from
627710d
to
b4fb60d
Compare
|
Thought given. |
|
Found two more things bork: Solus Update Service and budgie-daemon when we get the notification that there are notifications. |
2 tasks
Signed-off-by: Evan Maddock <maddock.evan@vivaldi.net>
EbonJaeger
dismissed
JoshStrobl’s stale review
Needs re-review due to new commit
JoshStrobl
approved these changes
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The notification spec states that the
desktop-entryhint should be the prefix of the Desktop Application Info file. However, because of the push to have fully-qualified app ID's, some applications now have a mismatch between the ID and the desktop file, meaning the hint cannot be used for that application.In cases where the hint fails, try to guess the ID using the application's name given to us from DBus.
It seems to fix #477.
Original description:
The spec states that the image data from a notification should be used before the application icon or any other icon. This change should reflect that.
It seems to fix #477. Nemo and Twitch Streamlink notifications now display properly in Raven on my system.
Signed-off-by: Evan Maddock maddock.evan@vivaldi.net
Submitter Checklist
git rebase -i(if needed)