Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add aggregate method to MongoDB #8117

Merged
merged 25 commits into from
Oct 13, 2022
Merged

Add aggregate method to MongoDB #8117

merged 25 commits into from
Oct 13, 2022

Conversation

melohagan
Copy link
Collaborator

@melohagan melohagan commented Oct 4, 2022

Description

You can now use aggregations in the MongoDB connector.

There are two modes:

  • JSON
  • Pipeline

In the JSON mode, you simply provide an array of objects that represent each stage, as per the API docs: https://www.mongodb.com/docs/manual/aggregation/#aggregation-pipeline-example

In the Pipeline mode, you are presented with stages that can be added with the UI. This might be more suitable for "low-code users".

Currently the json and pipeline modes store data separately, but it could be changed to allow mapping between the two.

Addresses:

Screenshots

JSON mode
Screenshot 2022-10-04 at 11 11 52

Dropdown stages with templates:

mongo

Swap stages

mongo

@codecov-commenter
Copy link

codecov-commenter commented Oct 12, 2022

Codecov Report

Merging #8117 (f9ed72f) into develop (a487dfc) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #8117   +/-   ##
========================================
  Coverage    67.08%   67.08%           
========================================
  Files          122      122           
  Lines         4123     4123           
  Branches       658      658           
========================================
  Hits          2766     2766           
  Misses         950      950           
  Partials       407      407           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Rory-Powell
Copy link
Contributor

Nice work mel, this is definitely a more low-code solution. I was wondering about the new Flow configuration type, where is that set on the new UI? I wasn't sure from the screenshots, is it the Action Type select?

I was thinking the term Flow might be a bit of an overloaded, and possibly something that might make more sense is to display Action Type as Query Type and use JSON or Form as the values

@melohagan
Copy link
Collaborator Author

Nice work mel, this is definitely a more low-code solution. I was wondering about the new Flow configuration type, where is that set on the new UI? I wasn't sure from the screenshots, is it the Action Type select?

I was thinking the term Flow might be a bit of an overloaded, and possibly something that might make more sense is to display Action Type as Query Type and use JSON or Form as the values

Changed 'flow' to 'pipeline' and renamed "Action Type" to "Query Type"

Copy link
Member

@shogunpurple shogunpurple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Great work Mel

packages/builder/src/components/integration/index.svelte Outdated Show resolved Hide resolved
packages/builder/src/components/integration/index.svelte Outdated Show resolved Hide resolved
@melohagan melohagan merged commit c3f556d into develop Oct 13, 2022
@melohagan melohagan deleted the lab/mongodb branch October 13, 2022 15:32
@github-actions github-actions bot locked and limited conversation to collaborators Oct 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants