feat(adapter): aws starter adapter

[leifermendez]

Desktop.22-3-2023.11-58-39.mp4

https://yzw42asu7a.execute-api.us-east-1.amazonaws.com/
This is the continuation of it #1784
npm run qwik add aws

• Improve

[stackblitz]

Run & review this pull request in StackBlitz Codeflow.

[zanettin]

first of all: you rock @leifermendez 😍 so cool!!

just had a qwik look at it and i got this error while testing it locally:

node_modules/.pnpm/serverless-plugin-qwik@1.0.5/node_modules/serverless-plugin-qwik: Running postinstall script, failed in 64ms
.../node_modules/serverless-plugin-qwik postinstall$ node ./update-yaml.js
│ node:internal/fs/utils:693
│     throw new ERR_INVALID_ARG_TYPE(propName, ['string', 'Buffer', 'URL'], path);
│     ^
│ TypeError [ERR_INVALID_ARG_TYPE]: The "path" argument must be of type string or an instance of Buffer or URL. Received undef
│     at Object.openSync (node:fs:593:10)
│     at Object.readFileSync (node:fs:469:35)
│     at addNewArrayItem (/Users/zanettin/development/qwik/qwik-app/node_modules/.pnpm/serverless-plugin-qwik@1.0.5/node_modul
│     at Object.<anonymous> (/Users/zanettin/development/qwik/qwik-app/node_modules/.pnpm/serverless-plugin-qwik@1.0.5/node_mo
│     at Module._compile (node:internal/modules/cjs/loader:1254:14)
│     at Module._extensions..js (node:internal/modules/cjs/loader:1308:10)
│     at Module.load (node:internal/modules/cjs/loader:1117:32)
│     at Module._load (node:internal/modules/cjs/loader:958:12)
│     at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:81:12)
│     at node:internal/main/run_main_module:23:47 {
│   code: 'ERR_INVALID_ARG_TYPE'
│ }
│ Node.js v18.15.0
└─ Failed in 64ms at /Users/zanettin/development/qwik/qwik-app/node_modules/.pnpm/serverless-plugin-qwik@1.0.5/node_modules/serverless-plugin-qwik
 ELIFECYCLE  Command failed with exit code 1.

 
 smth u'r aware of? will try it again later 👍
 
 and i left some questions you maybe already thought about 👼
 maybe it's a dependency of any other pkg (since the install failed i was not able to validate it), but i'd expect to see an dev install of serverless-offline.
 
 thanks once again 🙏

[zanettin]

imo a deploy and remove cmd would be nice as well 👼 but would require a local aws profile

[leifermendez]

I did not add the serverless:deploy because of that point is necessary AWS profile. I think maybe explain on the docs

[manucorporat]

do we need thr adapter.js? could all be part of entry.aws.ts? also wonder if we need express, it's only overhead at this point. Google Cloud Run is based in node, but without express!

[leifermendez]

do we need thr adapter.js? could all be part of entry.aws.ts? also wonder if we need express, it's only overhead at this point. Google Cloud Run is based in node, but without express!

I'll investigate about it

[manucorporat]

Also, thinking it should be called adapter/aws-lambda, aws has so many products that we will never know... also fits better with other adapters like: google-cloud-run, cloudflares-pages, etc...

[manucorporat]

Looking forward to merge this in the 1.2.0 window!

[leifermendez]

Looking forward to merge this in the 1.2.0 window!

Perfect! I was yesterday working with it. Today I'll continue.
btw check your discord when you can

[leifermendez]

[leifermendez]

@manucorporat

[zanettin]

Hi @leifermendez 👋
Thanks a lot for all the updates <3 it's also working on my end now 🙏

maybe u want to consider also any of these inputs:

• pnpm serverless:preview fails if pnpm build was not executed beforehand. imo we should change the npm script to build first and then run sls similar to what pnpm preview does
• what was the reason to switch the filename to entry_aws-lambda.tsx instead of entry.aws-lambda.tsx? the entry file for a cloudflare config would look like entry.cloudflare-pages.tsx as well
• what do you think about extending/updating the serverless.yml file with/on these keys?
  • service: qwik-lambda-app
  • provider.region: us-west-1
  • provider.memorySize: 128
  • provider.timeout: 10
  • provider.stage: dev

can also give u a hand if needed 👍
thanks a lot once again 🙏

[leifermendez]

Hi @leifermendez 👋 Thanks a lot for all the updates <3 it's also working on my end now 🙏

maybe u want to consider also any of these inputs:

• pnpm serverless:preview fails if pnpm build was not executed beforehand. imo we should change the npm script to build first and then run sls similar to what pnpm preview does

• what was the reason to switch the filename to entry_aws-lambda.tsx instead of entry.aws-lambda.tsx? the entry file for a cloudflare config would look like entry.cloudflare-pages.tsx as well

• what do you think about extending/updating the serverless.yml file with/on these keys?

  • service: qwik-lambda-app
  • provider.region: us-west-1
  • provider.memorySize: 128
  • provider.timeout: 10
  • provider.stage: dev

can also give u a hand if needed 👍 thanks a lot once again 🙏

Thanks for the feedback
About it entry_aws-lambda.tsx the situation is because AWS handle the entry point with format separated by dot.
AWS_INFO

Example: I need to call qwikApp function inside entry.aws-lambda.tsx in this case aws understand entry ==> aws-lambda but really my function is qwikApp

The rest of the feedback I'll work today

[zanettin]

ah yes 🙈 true. thanks

[leifermendez]

ah yes 🙈 true. thanks

Done 😎

[manucorporat]

Ready to merge @leifermendez ?

[leifermendez]

Ready to merge @leifermendez ?

Ohh yeah!

[manucorporat]

MERGED! this is amazing @leifermendez! gonna make some good noise with with in the 1.2.0 release

[leifermendez]

MERGED! this is amazing @leifermendez! gonna make some good noise with with in the 1.2.0 release

Thanks 🙏 for your support @manucorporat @zanettin 💪

[zanettin]

yeah!! congrats @leifermendez 🎉 and thx a lot!!

[KenParsons]

Thank you all for the hard work - this is amazing!!