Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
merged branch dpb587/pr-cleanup-some-tests (PR symfony#5737)
This PR was merged into the master branch. Commits ------- 3d2a7db Fix a few namespaces to match file system. Discussion ---------- Cleanup Some Tests - tearDown and namespaces Tried to cleanup a few tests and fix a few test classes which weren't following PSR-0. Removed original `tearDown` changes. --- Bug fix: no Feature addition: no Backwards compatibility break: no Symfony2 tests pass: yes Fixes the following tickets: ~ Todo: ~ License of the code: MIT Documentation PR: ~ --------------------------------------------------------------------------- by pborreli at 2012-10-13T06:41:14Z from [PHPUnit documentation](http://www.phpunit.de/manual/current/en/fixtures.html#fixtures.more-setup-than-teardown) : >setUp() and tearDown() are nicely symmetrical in theory but not in practice. In practice, you only need to implement tearDown() if you have allocated external resources like files or sockets in setUp(). If your setUp() just creates plain PHP objects, you can generally ignore tearDown(). However, if you create many objects in your setUp(), you might want to unset() the variables pointing to those objects in your tearDown() so they can be garbage collected. The garbage collection of test case objects is not predictable. --------------------------------------------------------------------------- by fabpot at 2012-10-13T10:05:49Z All these tearDown methods are not needed and should be removed.
- Loading branch information