Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add provinces data. #10

Closed
ByMykel opened this issue Apr 2, 2023 · 0 comments
Closed

Add provinces data. #10

ByMykel opened this issue Apr 2, 2023 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest help wanted Extra attention is needed

Comments

@ByMykel
Copy link
Owner

ByMykel commented Apr 2, 2023 •
edited
Loading

Steps

You can find all data in this Wikipedia article

  • Go to the province you are looking for.
    image

  • On the right side you will find all the data.
    image

  • Get the correct link for flag and coat_of_arms. Should be like https://upload.wikimedia.org/wikipedia/...
    image

You have to make the changes in src/data/names/provinces.json
@ByMykel ByMykel added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Aug 10, 2023
@ByMykel ByMykel changed the title Add provinces flags. Add provinces data. Aug 10, 2023
@ByMykel ByMykel pinned this issue Aug 10, 2023
@ByMykel ByMykel closed this as completed Oct 8, 2023
@ByMykel ByMykel unpinned this issue Oct 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ByMykel