submodule discovery and opening #484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ough. (#482) We currently detect them as possibly bare, which could be improved if we allow ourselves to see `.git/modules` as `submodule` always.
…#482) That way we can avoid feeding `.git` files to `git-repository::open()` and avoid work duplication, which ultimately allows to open submodules directories of all kinds.
…cating a Vec each time. (#482)
This includes submodule checkouts as well as their original module git directories.
…482) It's actually used by `ein t organize` so we should keep it, and it's probably useful
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tasks
git-discovercan find submodule workdirsgit-repositorycan open themFixes #482 and helps resolving starship/starship#4266