Fixes and Improvements #949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Byron
force-pushed
the
fixes-and-improvements
branch
from
9a4bb18
to
428bae1
Compare
Previously it was possible for reqwest to fail and cause a panic. Now the actual error will be returned to the original caller.
Further, we update internal logic to decide when to write a reflog for symrefs. Now we will always do it when possible, i.e. there is object ids available.
This allows symbolic refs to be parsed which are in fact pointing to an annotated tag as in-between object.
Byron
force-pushed
the
fixes-and-improvements
branch
from
428bae1
to
1dc045d
Compare
Byron
force-pushed
the
fixes-and-improvements
branch
from
1dc045d
to
c7e14b2
Compare
…ogical consistency. Previously, refspecs couldn't be used to update sybolic references locally, particularly because the logic to do so correctly isn't trivial and `git` itself also seems to cover only the most common cases. However, the logic now changed so that remote updates will only be rejected if * fast-forward rules are violated * the local ref is currently checked out * existing refs would not become 'unborn', i.e. point to a reference that doesn't exist and won't be created due to ref-specs This makes it possible to update unborn remote refs to local refs if these are new or unborn themselves. This also allows to create mirrors more easily and allows us to handle `HEAD` without special casing it. Bare repositories have an easier time to update local symbolic refs.
Byron
force-pushed
the
fixes-and-improvements
branch
from
c7e14b2
to
74ce863
Compare
Negative date offsets seem to occour with double-dashes, too.
…mall packs. When fetching, currently each of these creates a possibly small pack. We can tackle this in many areas, so ideally there is a best algorithm for this, maybe it is indeed just recency, or there is a selection. Have to figure that out. Further, small packs should be exploded, using `fetch.unpackLimit`.
…ns of arguments that are supposed to be features. This differentiation is important to support V1 and V2 correctly, which have a different notion of features with V1 special-casing them, and V2 just sees everything as arguments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tasks
gix::transport::client::blocking_io::http::reqwest::Remoteerrors too late #923HEADwith a remote refspec if there is a worktree - actually it doesn't allow to write into any other place thanrefs/.the intermediate ref should then be created, too, as the peeled value is knownlet's leave it as 'unborn' then but document that beahviourgitoxide-core: visualize ref type change as wellgixfails to decode commit object thatgithas no trouble with #950